The current Snippet campaign to open about:logins is opening the URL about:logins directly and therefore not passing an ?entryPoint=… argument. We should have them pass a new value of "snippet" otherwise they get counted as "direct" and will skew that data.

The URL will then be about:logins?entryPoint=snippet.

Comment on attachment 9133731 [details]
Bug 1622971 - Add a "snippet" object for the pwmgr.open_management telemetry event. r=sfoster

Within scope of the review on bug 1550631.

Comment on attachment 9133731 [details]
Bug 1622971 - Add a "snippet" object for the pwmgr.open_management telemetry event. r=sfoster

Beta/Release Uplift Approval Request

• User impact if declined: Snippets that open about:logins skew data on how users open about:logins so we may make incorrect assumptions and bad decisions as a result of the bad data.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simply adding a new allowed value for a telemetry event that snippets can use. If there was a problem then we could change the snippet on the server easily. It's also low risk since current snippets aren't using this now so it's basically dead code until they do.
• String changes made/needed: None

https://hg.mozilla.org/mozilla-central/rev/a800c69e9e9e

Comment on attachment 9133731 [details]
Bug 1622971 - Add a "snippet" object for the pwmgr.open_management telemetry event. r=sfoster

Low risk, uplift approved for 75 beta 6, thanks.

https://hg.mozilla.org/releases/mozilla-beta/rev/6472239e8a26

Giorgos, for any snippets targeting Fx76 and newer which open about:logins, please use the URL about:logins?entryPoint=snippet which means using the OPEN_ABOUT_PAGE action with an argument of logins?entryPoint=snippet.

For snippets which include an audience of Fx75 or earlier, please don't pass the entryPoint or it will cause it to not record our telemetry in that case.

Thanks

It's very complicated to target specific versions for this change. Maybe we can do this on the ASR level, tagging Andrei for input.

BTW would it make sense we set ?entryPoint=snippet for all OPEN_ABOUT_PAGE actions?

(In reply to Giorgos Logiotatidis [:giorgos] from comment #9)

BTW would it make sense we set ?entryPoint=snippet for all OPEN_ABOUT_PAGE actions?

This argument value is specific to about:logins. about:preferences has something similar but for that you should use OPEN_PREFERENCES_PAGE with the entryPoint property adjacent to the category property:

            {
              category: "sync",
              entrypoint: "<some-entrypoint>", // Maybe talk to the FxA team about the value to use here. They use hyphens between words (kebab-case)
            }

(bug 1619422)

It's very complicated to target specific versions for this change

Older versions won't complain. We can do this for all snippets.

(In reply to Andrei Oprea [:andreio] from comment #11)

It's very complicated to target specific versions for this change

Older versions won't complain. We can do this for all snippets.

They will complain about the telemetry object not being allowed and then won't record the telemetry which is worse than skewing it, see below:

(Quoting Matthew N. [:MattN] from comment #8)

For snippets which include an audience of Fx75 or earlier, please don't pass the entryPoint or it will cause it to not record our telemetry in that case.

@Giorgos is there any snippet available so we can verify this issue? If not can you please ping me when one is available?

This has not been fixed on the snippets side yet as there is no conclusion on what we do with older versions. I believe that this should be a Message Router fix if we don't want to lose pings from older versions. Pinging Andrei for another comment

Created a follow up bug.

(In reply to Giorgos Logiotatidis [:giorgos] from comment #14)

This has not been fixed on the snippets side yet as there is no conclusion on what we do with older versions. I believe that this should be a Message Router fix if we don't want to lose pings from older versions. Pinging Andrei for another comment

Snippets service has been updated to work with updates from bug 1628688. Related issue https://github.com/mozmeao/snippets-service/issues/1355

(In reply to Cosmin Muntean [:cmuntean], Ecosystem QA from comment #13)

@Giorgos is there any snippet available so we can verify this issue? If not can you please ping me when one is available?

There's no snippet that uses this functionality atm. Snippet content is controlled by the Own Media Network team and not me. I'll keep an eye but I don't know when one will come alive. BTW most of snippets have been pulled off due to COVID

Thank you, Giorgos! Please let me know if you found out that a snippet is available so we can verify this issue.