Closed
Bug 1623350
Opened 5 years ago
Closed 5 years ago
Remove any reference to tabAttached
Categories
(DevTools :: Framework, task, P1)
DevTools
Framework
Tracking
(Fission Milestone:M6, firefox76 fixed)
Tracking | Status | |
---|---|---|
firefox76 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
Details
(Whiteboard: dt-fission-m2-mvp)
Attachments
(4 files)
There is mentioned of a tabAttached
event:
https://searchfox.org/mozilla-central/search?path=&q=tabAttached
But this isn't used.
And the usage of type
attribute in the response of the attach method over here:
https://searchfox.org/mozilla-central/source/devtools/server/actors/targets/browsing-context.js#996-1003
might actually make this response become an event.
So we should clean this up by removing this attribute and all reference to tabAttached.
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED
Priority: -- → P1
Whiteboard: dt-fission-m2-mvp
Assignee | ||
Comment 1•5 years ago
|
||
Assignee | ||
Comment 2•5 years ago
|
||
Assignee | ||
Comment 3•5 years ago
|
||
Assignee | ||
Comment 4•5 years ago
|
||
Assignee | ||
Comment 5•5 years ago
|
||
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ff6cd60c7a6b
Remove references to tabAttached. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/9c4b273fd66d
Convert exited response to an error. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/e0f4381591e1
Stop returning anything from detach and process error as rejection. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/5ef7a8a12cc1
Process BrowsingContextTargetActor error as exceptions. r=jdescottes
Comment 7•5 years ago
|
||
Tracking Fission DevTools bugs for Fission Nightly (M6) milestone
Fission Milestone: --- → M6
Comment 8•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ff6cd60c7a6b
https://hg.mozilla.org/mozilla-central/rev/9c4b273fd66d
https://hg.mozilla.org/mozilla-central/rev/e0f4381591e1
https://hg.mozilla.org/mozilla-central/rev/5ef7a8a12cc1
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox76:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 76
You need to log in
before you can comment on or make changes to this bug.
Description
•