Closed
Bug 1623462
Opened 5 years ago
Closed 5 years ago
Chunking method loads unix runtime for windows tests
Categories
(Firefox Build System :: Task Configuration, defect)
Firefox Build System
Task Configuration
Tracking
(firefox76 fixed)
RESOLVED
FIXED
mozilla76
Tracking | Status | |
---|---|---|
firefox76 | --- | fixed |
People
(Reporter: egao, Assigned: egao)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
In this section of chunking.py where test runtimes are taken into account:
for key in ('android', 'windows'):
if key in platform:
path = base.format(key)
break
The platform
argument which is passed into this method specifies win
for windows
, but the if
statement checks if it is windows
, resulting in a the check always returning a False
when the platform is windows.
This results in the later section of the method loading the unix
test runtimes instead of windows
.
Assignee | ||
Comment 1•5 years ago
|
||
Updated•5 years ago
|
Assignee: nobody → egao
Status: NEW → ASSIGNED
Pushed by egao@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/62002e37592a
fix incorrect check of windows platform value in chunking.py r=ahal
Comment 3•5 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox76:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
You need to log in
before you can comment on or make changes to this bug.
Description
•