Closed Bug 1623638 Opened 5 years ago Closed 4 years ago

Support adding "external image" surfaces with scaling in the compositor interface

Categories

(Core :: Graphics: WebRender, enhancement, P3)

Product:
Core
Component:
Graphics: WebRender
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: jrmuizel, Unassigned)

References

(Blocks 1 open bug)

Details

The main motivation for this is being able to scale video using the os compositor.

Blocks: 1623530
Blocks: 1622966
Blocks: 1460499
Priority: -- → P3
Blocks: 1653048
Summary: Support scaling in the compositor interface → Support adding "external image" surfaces with scaling in the compositor interface

Glenn, I remember you telling me about an API sketch for this at some point. Do you still recall what it looked like?

Flags: needinfo?(gwatson)

I don't recall exactly - the basic idea was that an external image could be annotated with a flag (either on the image or prim) saying that this video should be handled as a native surface, rather than WR allocating a native surface and drawing into it.

Then, WR compositor interface would effectively see this surface as a placeholder, and ask the Compositor trait to add it to the scene at the correct time / location.

We can perhaps discuss in a zoom call if we want to sketch out something more detailed than that.

Flags: needinfo?(gwatson)

Discussed this with Glenn a bit more.

We can add scaling to the Compositor API separately from adding support for external images.

I'll split off a separate bug just for the scaling subset, and start working on that.

Depends on: 1653166

This was taken care of in bug 1653048, right? Or are you planning to do anything else in this bug?

Flags: needinfo?(matt.woodrow)
Status: NEW → RESOLVED
Closed: 4 years ago
Flags: needinfo?(matt.woodrow)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.