Remove js::IterateLazyScripts
Categories
(Core :: JavaScript Engine, task, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox83 | --- | fixed |
People
(Reporter: tcampbell, Assigned: tcampbell)
References
(Blocks 2 open bugs)
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
Once Bug 1623761 removes the need for special handling betwen lazy and non-lazy BaseScript
instances, we should remove the IterateLazyScripts
API entirely. Instead, IterateScripts should fire its callback for all BaseScripts
. Most uses of IterateScripts
will do the right thing, but each one will need to be checked.
Assignee | ||
Comment 1•5 years ago
|
||
Note that the code in [1] is for old systems that have since been removed and can be ignored. The two consider
functions can be merged to just respond to any BaseScript
.
Comment 2•5 years ago
|
||
u7693: Here's another bug for you to look at. A bit more complicated, but something you can start looking over.
Assignee | ||
Comment 3•5 years ago
|
||
A good starting point would be to simply all of [1] to a single case. In Comment 1 I have a few tips for what you can ignore.
Without solving Bug 1623761, you might be able to still make progress at removing IterateLazyScripts
by putting a hasBytecode
test in [2].
Another tip is that for [3], you can allow any lazy/non-lazy BaseScript
through because the function is only called when the lazy syntax-only parser is fully disabled.
[1] https://searchfox.org/mozilla-central/rev/6cd54550a27e2f6ca0755a25328f769e41e524f4/js/src/debugger/Debugger.cpp#5433-5483
[2] https://searchfox.org/mozilla-central/rev/6cd54550a27e2f6ca0755a25328f769e41e524f4/js/src/debugger/Debugger.cpp#5169-5179
[3] https://searchfox.org/mozilla-central/rev/6cd54550a27e2f6ca0755a25328f769e41e524f4/js/src/vm/BytecodeUtil.cpp#2918
Comment 4•5 years ago
|
||
I would like to work on this bug.
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 5•4 years ago
|
||
Remove the IterateLazyScripts
API and have IterateScripts
fire for all
BaseScript whether they have bytecode or not. Update the uses in the debugger
to support this change in behaviour.
Depends on D93039
Comment 7•4 years ago
|
||
bugherder |
Description
•