Closed Bug 1624146 Opened 5 years ago Closed 5 years ago

Refactor nsCookieService.cpp

Categories

(Core :: Networking: Cookies, task, P3)

Product:
Core
Component:
Networking: Cookies
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla77
Tracking Flags:
Tracking Status
firefox77 --- fixed

People

(Reporter: baku, Assigned: baku)

References

Details

(Whiteboard: [necko-triaged])

Attachments

(16 files, 2 obsolete files)

Bug 1624146 - Cookie code refactoring - part 1 - Cookie, r?ehsan
(deleted), text/x-phabricator-request
Details
Bug 1624146 - Cookie code refactoring - part 2 - CookieKey, r?ehsan
(deleted), text/x-phabricator-request
Details
Bug 1624146 - Cookie code refactoring - part 3 - CookiePermission, r?ehsan
(deleted), text/x-phabricator-request
Details
Bug 1624146 - Cookie code refactoring - part 4 - DBState renamed CookieStorage, r?ehsan
(deleted), text/x-phabricator-request
Details
Bug 1624146 - Cookie code refactoring - part 5 - Separate files for CookieStorage, r?ehsan
(deleted), text/x-phabricator-request
Details
Bug 1624146 - Cookie code refactoring - part 6 - CookieStorage, r?ehsan
(deleted), text/x-phabricator-request
Details
Bug 1624146 - Cookie code refactoring - part 7 - CookiePrivateStorage and CookieDefaultStorage, r?ehsan
(deleted), text/x-phabricator-request
Details
Bug 1624146 - Cookie code refactoring - part 8 - CookieStorage observers pref changes, r?ehsan
(deleted), text/x-phabricator-request
Details
Bug 1624146 - Cookie code refactoring - part 9 - DB handling in CookieDefaultStorage, r?ehsan
(deleted), text/x-phabricator-request
Details
Bug 1624146 - Cookie code refactoring - part 10 - CookieService under mozilla::net, r?ehsan
(deleted), text/x-phabricator-request
Details
Bug 1624146 - Cookie code refactoring - part 11 - Separate files for CookiePrivateStorage and CookiePersistentStorage, r?ehsan
(deleted), text/x-phabricator-request
Details
Bug 1624146 - Cookie code refactoring - part 12 - Header cleanup, r?ehsan
(deleted), text/x-phabricator-request
Details
Bug 1624146 - Cookie code refactoring - part 13 - More functions in CookieCommons, r?ehsan
(deleted), text/x-phabricator-request
Details
Bug 1624146 - Cookie code refactoring - part 14 - Fix the namespaces, r?ehsan
(deleted), text/x-phabricator-request
Details
Bug 1624146 - Cookie code refactoring - part 15 - Remove mozIStorage* from CookieStorage, r?ehsan
(deleted), text/x-phabricator-request
Details
Bug 1624146 - Cookie code refactoring - part 16 - Modernize c++ code, r?smaug
(deleted), text/x-phabricator-request
Details

This code is doing too much for a single file. Let's clean up the code.
The new configuration is:

  • CookieStorage: a generic class to store cookies.
  • CookiePrivateStorage: a CookieStorage implementation for private-browsing
  • CookiePersistentStorage: a CookieStorage implementation for normal browsing
  • CookieService: the previous nsCookieService
  • CookieCommons: generic functions
  • CookieLogging: logging methods.

Depends on D67749

Whiteboard: [necko-triaged]
Priority: -- → P3
Attachment #9135492 - Attachment is obsolete: true
Attachment #9135493 - Attachment is obsolete: true
Blocks: 1624286

Btw, I think this should land after the next merge, which is next week.

Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fc7a4f028bd4 Cookie code refactoring - part 1 - Cookie, r=smaug https://hg.mozilla.org/integration/autoland/rev/ceaf03a667e8 Cookie code refactoring - part 2 - CookieKey, r=smaug https://hg.mozilla.org/integration/autoland/rev/725ea3651ab1 Cookie code refactoring - part 3 - CookiePermission, r=smaug https://hg.mozilla.org/integration/autoland/rev/650b38e09eff Cookie code refactoring - part 4 - DBState renamed CookieStorage, r=smaug https://hg.mozilla.org/integration/autoland/rev/c231dd605d08 Cookie code refactoring - part 5 - Separate files for CookieStorage, r=smaug https://hg.mozilla.org/integration/autoland/rev/ef3152991931 Cookie code refactoring - part 6 - CookieStorage, r=smaug https://hg.mozilla.org/integration/autoland/rev/4296c8aa8db3 Cookie code refactoring - part 7 - CookiePrivateStorage and CookieDefaultStorage, r=smaug https://hg.mozilla.org/integration/autoland/rev/8f08ef21a89c Cookie code refactoring - part 8 - CookieStorage observers pref changes, r=smaug https://hg.mozilla.org/integration/autoland/rev/aa78111058f7 Cookie code refactoring - part 9 - DB handling in CookieDefaultStorage, r=smaug https://hg.mozilla.org/integration/autoland/rev/8566c9426589 Cookie code refactoring - part 10 - CookieService under mozilla::net, r=smaug https://hg.mozilla.org/integration/autoland/rev/3d356d8f5f01 Cookie code refactoring - part 11 - Separate files for CookiePrivateStorage and CookiePersistentStorage, r=smaug https://hg.mozilla.org/integration/autoland/rev/ec78496d9606 Cookie code refactoring - part 12 - Header cleanup, r=smaug https://hg.mozilla.org/integration/autoland/rev/406dfffcce59 Cookie code refactoring - part 13 - More functions in CookieCommons, r=smaug https://hg.mozilla.org/integration/autoland/rev/f61489f19686 Cookie code refactoring - part 14 - Fix the namespaces, r=smaug https://hg.mozilla.org/integration/autoland/rev/09afbdd67bd4 Cookie code refactoring - part 15 - Remove mozIStorage* from CookieStorage, r=smaug https://hg.mozilla.org/integration/autoland/rev/13083ce12410 Cookie code refactoring - part 16 - Modernize c++ code, r=smaug
Regressions: 1628298
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: