Switch android emulator to be pulled via toolchain instead of tooltool
Categories
(Firefox Build System :: Task Configuration, enhancement, P1)
Tracking
(firefox78 fixed)
Tracking | Status | |
---|---|---|
firefox78 | --- | fixed |
People
(Reporter: tomprince, Assigned: gbrown)
References
(Regressed 1 open bug)
Details
Attachments
(2 files)
Currently, we build android emulator packages manually and upload them to tooltool. It would be better to build them in-tree as private artifacts via toolchain jobs.
The current code for packing sdks is here and here. There are instructions here on mana (private) about how the current tooltool package is built. Looking at the instructions and existing script, it may be possible to use the existing packages; with just some adjustment to expected paths.
There will also need to be adjustments to remove the existing files from the tooltool manifests, adding the appropriate fetch
stanza to tasks that need it, and dealing with the differences between where tooltool and fetch-content
extract downloads.
Updated•5 years ago
|
Comment 1•5 years ago
|
||
Currently, we build android emulator packages manually and upload to
tooltool.
This patch switches it to be pulled from the toolchain built artifacts.
This also allows android tests to run in the staging environment.
Comment 3•5 years ago
|
||
Backed out changeset 0592b572c58d (bug 1624649) for many failures complaining about minidump_stackwalk path
Backout link: https://hg.mozilla.org/integration/autoland/rev/1cddc2938e75fa6ed39192891c386e9ff7d58904
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=295810461&repo=autoland&lineNumber=978
[task 2020-04-01T18:39:23.917Z] 18:39:23 INFO - Running pre test command restart windows explorer with 'powershell -command "&{&Stop-Process -ProcessName explorer}"'
[task 2020-04-01T18:39:23.917Z] 18:39:23 INFO - Running command: ('powershell', '-command', '"&{&Stop-Process -ProcessName explorer}"') in Z:\task_1585763962\build
[task 2020-04-01T18:39:23.917Z] 18:39:23 INFO - Copy/paste: powershell -command "\"&{&Stop-Process -ProcessName explorer}\""
[task 2020-04-01T18:39:24.659Z] 18:39:24 INFO - &{&Stop-Process -ProcessName explorer}
[task 2020-04-01T18:39:24.683Z] 18:39:24 INFO - Return code: 0
[task 2020-04-01T18:39:24.712Z] 18:39:24 INFO - Unable to complete system-info.log: <type 'exceptions.TypeError'>
[task 2020-04-01T18:39:24.712Z] 18:39:24 INFO - #### Running mochitest suites
[task 2020-04-01T18:39:24.712Z] 18:39:24 INFO - Structured output parser in use for mochitest.
[task 2020-04-01T18:39:24.733Z] 18:39:24 ERROR - minidump_stackwalk path was not fetched?
[task 2020-04-01T18:39:24.733Z] 18:39:24 WARNING - # TBPL WARNING #
[task 2020-04-01T18:39:24.733Z] 18:39:24 WARNING - setting return code to 1
Comment 4•5 years ago
|
||
(In reply to Bogdan Tara[:bogdan_tara | bogdant] from comment #3)
Backed out changeset 0592b572c58d (bug 1624649) for many failures complaining about minidump_stackwalk path
Backout link: https://hg.mozilla.org/integration/autoland/rev/1cddc2938e75fa6ed39192891c386e9ff7d58904
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=295810461&repo=autoland&lineNumber=978
[task 2020-04-01T18:39:23.917Z] 18:39:23 INFO - Running pre test command restart windows explorer with 'powershell -command "&{&Stop-Process -ProcessName explorer}"' [task 2020-04-01T18:39:23.917Z] 18:39:23 INFO - Running command: ('powershell', '-command', '"&{&Stop-Process -ProcessName explorer}"') in Z:\task_1585763962\build [task 2020-04-01T18:39:23.917Z] 18:39:23 INFO - Copy/paste: powershell -command "\"&{&Stop-Process -ProcessName explorer}\"" [task 2020-04-01T18:39:24.659Z] 18:39:24 INFO - &{&Stop-Process -ProcessName explorer} [task 2020-04-01T18:39:24.683Z] 18:39:24 INFO - Return code: 0 [task 2020-04-01T18:39:24.712Z] 18:39:24 INFO - Unable to complete system-info.log: <type 'exceptions.TypeError'> [task 2020-04-01T18:39:24.712Z] 18:39:24 INFO - #### Running mochitest suites [task 2020-04-01T18:39:24.712Z] 18:39:24 INFO - Structured output parser in use for mochitest. [task 2020-04-01T18:39:24.733Z] 18:39:24 ERROR - minidump_stackwalk path was not fetched? [task 2020-04-01T18:39:24.733Z] 18:39:24 WARNING - # TBPL WARNING # [task 2020-04-01T18:39:24.733Z] 18:39:24 WARNING - setting return code to 1
Ok, that is unexpected, I understood the patch should only affect android-x86[_64]. Let me investigate this
Updated•5 years ago
|
Comment 5•5 years ago
|
||
:nalexander, I pushed another version of the patch, would you mind reviewing it?
Comment 6•5 years ago
|
||
(In reply to Wander Lairson Costa from comment #5)
:nalexander, I pushed another version of the patch, would you mind reviewing it?
If it's green for you, it's good for me.
Comment 8•5 years ago
|
||
Backed out for failing wrench
Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=297985605&resultStatus=testfailed%2Cbusted%2Cexception&revision=1ad3c93e1e07ee5a22a2a19efc70928d9d2f3661
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=297985605&repo=autoland&lineNumber=144
Backout: https://hg.mozilla.org/integration/autoland/rev/65951cbe72774d0c2151f5d4b34c0ccbe6316ddb
Comment 9•5 years ago
|
||
(In reply to Andreea Pavel [:apavel] from comment #8)
Backed out for failing wrench
Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=297985605&resultStatus=testfailed%2Cbusted%2Cexception&revision=1ad3c93e1e07ee5a22a2a19efc70928d9d2f3661
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=297985605&repo=autoland&lineNumber=144
Backout: https://hg.mozilla.org/integration/autoland/rev/65951cbe72774d0c2151f5d4b34c0ccbe6316ddb
Thanks for taking action so fast! I am going to fix my patch.
Updated•5 years ago
|
Assignee | ||
Comment 10•5 years ago
|
||
This seems really close. I'll try to push it over the line...
Comment 11•5 years ago
|
||
(In reply to Geoff Brown [:gbrown] from comment #10)
This seems really close. I'll try to push it over the line...
The latest version I have is here. Theoretically it should work, but I don't know why even after fixing wrench.py it keeps looking for adb
in the tooltool
path.
Assignee | ||
Comment 12•5 years ago
|
||
This is very similar to wcosta's earlier patch, with a few adjustments to overcome
special cases:
- remove the wrench override of adb path; handle in config instead
- fix taskcluster config syntax in a couple of places
- add android-sdk-linux fetch for test-verify
Comment 13•5 years ago
|
||
Comment 14•5 years ago
|
||
bugherder |
Description
•