Closed
Bug 1624889
Opened 4 years ago
Closed 4 years ago
Opening RDM from the Style Editor does not set the viewport dimensions specified by the media query
Categories
(DevTools :: Responsive Design Mode, defect, P1)
DevTools
Responsive Design Mode
Tracking
(firefox-esr68 unaffected, firefox74 unaffected, firefox75 unaffected, firefox76 verified)
VERIFIED
FIXED
Firefox 76
| Tracking | Status | |
|---|---|---|
| firefox-esr68 | --- | unaffected |
| firefox74 | --- | unaffected |
| firefox75 | --- | unaffected |
| firefox76 | --- | verified |
People
(Reporter: mtigley, Assigned: mtigley)
References
(Blocks 1 open bug, Regression)
Details
(Keywords: regression)
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
STR
- Go to any website with screen
min/max-widthmedia queries specified in their stylesheet. - Open the Style Editor and click on any of the media query links to open RDM.
Expected
RDM opens with the viewport dimensions set to the media query values
Actual
RDM ignores the viewport dimensions it was opened with. It just shows the values previously selected.
This was regressed by Bug 1621306 when fixing the style editor test because the call to RDM UI's setViewportSize was moved into the test instead of keeping it in https://searchfox.org/mozilla-central/source/devtools/client/styleeditor/StyleEditorUI.jsm#1103. See: https://phabricator.services.mozilla.com/D66246
|
Assignee | |
Updated•4 years ago
|
Priority: -- → P1
|
|
Assignee | |
Comment 1•4 years ago
|
||
Pushed by mtigley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/22baf134cf80 Ensure RDM sets the viewport width and height when opened from the Style Editor r=bradwerth
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox76:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 76
|
||
Updated•4 years ago
|
Keywords: regression
|
||
Updated•4 years ago
|
status-firefox74:
--- → unaffected
status-firefox75:
--- → unaffected
status-firefox-esr68:
--- → unaffected
|
||
Comment 4•4 years ago
|
||
This issue is Verified as Fixed in our latest Nightly build 76.0a1 (2020-03-30) On Windows 10, MAC 10.15 and Ubuntu 18.04.
Status: RESOLVED → VERIFIED
|
||
Updated•4 years ago
|
Has Regression Range: --- → yes
You need to log in
before you can comment on or make changes to this bug.
Description
•