Refactor DNS code to remove OnLookupByTypeComplete
Categories
(Core :: Networking: DNS, task, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox77 | --- | fixed |
People
(Reporter: valentin, Assigned: valentin)
References
Details
(Whiteboard: [necko-triaged])
Attachments
(3 files)
We can pass TXT records via onLookupComplete without any issues of we make nsIDNSByTypeRecord extend nsIDNSRecord
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
This patch makes nsIDNSByTypeRecord extend nsIDNSRecord, but implementations
will safely forward the nsIDNSRecord methods to nullptr, meaning they will
throw an error when called.
Consumers should try to QI the nsIDNSRecord to nsIDNSByTypeRecord (or any
future types) and use that.
Depends on D69325
|
|
Assignee | |
Comment 3•5 years ago
|
||
It seems there was no unit test exercising this code in e10s.
This copies the simple test from test_esni_dns_fetch.js to make sure
we have a little code coverage for the IPC code too.
Depends on D69326
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/20045db24ba9
https://hg.mozilla.org/mozilla-central/rev/b6cc4ee41f8b
https://hg.mozilla.org/mozilla-central/rev/d90108f9a85d
Description
•