Closed Bug 1625541 Opened 5 years ago Closed 3 years ago

Should make it more clear that the profiler can't be started with a private browser window open

Categories

(DevTools :: Performance Tools (Profiler/Timeline), enhancement, P2)

enhancement

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: gregtatum, Unassigned)

References

Details

Moved from https://github.com/firefox-devtools/Gecko-Profiler-Addon/issues/96.

This was an issue with the add-on, and is still affecting the new popup. The STR mostly reproduces, all you have to do it have an open private browsing window, and it doesn't react. The DevTools panel handles this case correctly and displays a message.

mconley wrote:

STR:

  • Turn the profiler add-on off.
  • Open up a private browsing window
  • Switch back to the original normal browsing window
  • Attempt to start the profiler.

ER:

At least for some folks, they might expect the profiler to start.

AR:

The profiler doesn't start. Clicking "Start" in the profiler action panel does nothing.

I understand why we're not starting the profiler - we don't want to collect potentially sensitive data from a PB window. We should, however, probably make it clear that this is why enabling the profiler isn't possible.

Priority: -- → P2

It seems like this works now - possibly due to fixing bug 1639716? Can this be marked resolved?

Flags: needinfo?(gtatum)
Status: NEW → RESOLVED
Closed: 3 years ago
Depends on: 1639716
Flags: needinfo?(gtatum)
Resolution: --- → WORKSFORME

This is correct. Thanks!

You need to log in before you can comment on or make changes to this bug.