Closed Bug 1625939 Opened 5 years ago Closed 2 years ago

Remove devtools.browsertoolbox.fission preference and only support the Multiprocess browser toolbox

Categories

(DevTools :: Framework, task)

Product:
DevTools
Component:
Framework
Type:
task

Tracking

(Fission Milestone:Future, firefox110 fixed)

Status:
RESOLVED FIXED
Milestone:
110 Branch
Project Flags:
Fission Milestone Future
Tracking Flags:
Tracking Status
firefox110 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

(Depends on 1 open bug, Blocks 4 open bugs)

Details

(Whiteboard: dt-fission-future)

Attachments

(5 files, 1 obsolete file)

Bug 1625939 - [devtools] Remove all test covering the non-multiprocess browser toolbox.
(deleted), text/x-phabricator-request
Details
Bug 1625939 - [devtools] Remove all places where we set devtools.browsertoolbox.fission to true.
(deleted), text/x-phabricator-request
Details
Bug 1625939 - [devtools] Remove devtools.browsertoolbox.fission preference and remove old non-fission Browser Toolbox.
(deleted), text/x-phabricator-request
Details
Bug 1625939 - [devtools] Remove reference to `isBrowserToolboxFission` and remove the related logic from server codebase.
(deleted), text/x-phabricator-request
Details
Bug 1625939 - [devtools] Remove cloned content message legacy listener.
(deleted), text/x-phabricator-request
Details

A few tests are still disabling the Multiprocess Browser Toolbox.
We would have to fix them before being able to get rid of the old non-multiprocess codepath:
https://searchfox.org/mozilla-central/search?q=browsertoolbox.fission%22%2C+false&case=false&regexp=false&path=

Fission Future because removing the pref doesn't need to block shipping Fission MVP.

Fission Milestone: --- → Future
Depends on: 1601891

Adding dt-fission whiteboard tag to DevTools bugs that mention Fission or block Fission meta bugs but don't already have a dt-fission whiteboard tag.

Whiteboard: dt-fission

Moving old "dt-fission" bugs to "dt-fission-future" because they don't block Fission MVP.

Whiteboard: dt-fission → dt-fission-future
Severity: normal → S3
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED

It looks like, none of these tests were actually buggy on the MBT.
They all meant to cover the non-MBT on purpose, mostly to cover the two codepaths.

The only exception is browser_aboutdebugging_process_main_local.js,
which was having trouble with the MBT. But it may now pass as the MBT
is by default focusing only on the parent process.

It looks like it was only used by the non-fission browser toolbox.
See the acceptTarget condition.

Assignee: nchevobbe → poirot.alex
Attachment #9308295 - Attachment description: Bug 1625939 - [devtools] Remove pref set to true → Bug 1625939 - [devtools] Remove all places where we set devtools.browsertoolbox.fission to true.
Attachment #9308296 - Attachment description: Bug 1625939 - [devtools] Remove pref from production code. → Bug 1625939 - [devtools] Remove devtools.browsertoolbox.fission preference and remove old non-fission Browser Toolbox.
Attachment #9308304 - Attachment description: Bug 1625939 - [devtools] Remove reference to isBrowserToolboxFission and remove the related logic from server codebase. → Bug 1625939 - [devtools] Remove reference to `isBrowserToolboxFission` and remove the related logic from server codebase.
Blocks: 1571632
Attachment #9308294 - Attachment is obsolete: true
Blocks: 1806404
Blocks: 1806405
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0170a5edf001 [devtools] Remove all test covering the non-multiprocess browser toolbox. r=nchevobbe https://hg.mozilla.org/integration/autoland/rev/141fa46c8b61 [devtools] Remove all places where we set devtools.browsertoolbox.fission to true. r=nchevobbe https://hg.mozilla.org/integration/autoland/rev/d6b87fe375c5 [devtools] Remove devtools.browsertoolbox.fission preference and remove old non-fission Browser Toolbox. r=nchevobbe,fluent-reviewers,flod,perftest-reviewers,kshampur https://hg.mozilla.org/integration/autoland/rev/0b0a7b1617ad [devtools] Remove reference to `isBrowserToolboxFission` and remove the related logic from server codebase. r=nchevobbe,devtools-backward-compat-reviewers https://hg.mozilla.org/integration/autoland/rev/40a9da59038d [devtools] Remove cloned content message legacy listener. r=nchevobbe
Regressions: 1808300
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: