Use the ResourceWatcher API to fetch CSS Changes
Categories
(DevTools :: Inspector: Changes, task, P2)
Tracking
(Fission Milestone:M6c, firefox79 fixed)
Tracking | Status | |
---|---|---|
firefox79 | --- | fixed |
People
(Reporter: ochameau, Assigned: daisuke)
References
(Regressed 1 open bug)
Details
(Whiteboard: dt-fission-m2-mvp)
Attachments
(4 files)
Bug 1576624 introduced the ResourceWatcher
API, accessible via toolbox.resourceWatcher
. This API will help listen to data that is being created early, when the document just started loading.
We should migrate the whole DevTools codebase to this API for any data that:
- DevTools frontend listen to, or care about,
and, - may be created or be notified early, when the document just starts being loaded.
This data will typically be: console messages, errors, warnings, sources, Root element NodeFront, storage values, network events, stylesheets, ...
We are typically not going to use this API for:
- data being fetched on-demand, from user's input. For ex: webconsole evaluation input, or, DOM element expands from the Markup view.
- events which we only want to record when the user cares about them. For ex: animation events.
For some more high level context, please have a look at Migration to Fission-compatible APIs, which describes all Fission-related refactorings.
The typical task for this bug will be about migrating code that:
- start listening and register a RDP event listener,
- retrieve already existings data,
from panel's codebase, to theResourceWatcher
module, in theLegacyListener
object.
And then, the panel should use theResourceWatcher
instead.
Bug 1620234 is a good example of such migration, applied to Console Messages.
Bug 1623699 is also useful example as it demonstrates how to write tests for such migration.
This bug is about focusing on only one usecase: the CSS changes.
We do request already existing changes, and start listening for the next ones from here:
https://searchfox.org/mozilla-central/rev/9c6e7500c0015a2c60be7b1b888261d95095ce27/devtools/client/inspector/compatibility/CompatibilityView.js#157-165
Reporter | ||
Updated•5 years ago
|
Reporter | ||
Updated•5 years ago
|
Comment 1•5 years ago
|
||
Tracking Fission DevTools bugs for Fission Nightly (M6) milestone
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 2•5 years ago
|
||
Assignee | ||
Comment 3•5 years ago
|
||
Depends on D74599
Assignee | ||
Comment 4•5 years ago
|
||
Depends on D74600
Assignee | ||
Comment 5•5 years ago
|
||
Depends on D74601
Comment 6•5 years ago
|
||
Tracking dt-fission-m2-mvp bugs for Fission Nightly milestone (M6c)
Comment 8•4 years ago
|
||
Backed out for perma failures on browser_inspector_sidebarstate.js.
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=306038173&repo=autoland&lineNumber=29510
Backout: https://hg.mozilla.org/integration/autoland/rev/593a07999f90a03ffda6dc4f620c851a11db5e7d
Assignee | ||
Updated•4 years ago
|
Comment 10•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2c71a91762d3
https://hg.mozilla.org/mozilla-central/rev/dfd589598959
https://hg.mozilla.org/mozilla-central/rev/f3982a7f1771
https://hg.mozilla.org/mozilla-central/rev/e860655e21e7
Updated•4 years ago
|
Description
•