Closed Bug 1625967 Opened 5 years ago Closed 5 years ago

The “Learn more” and the “Go to <website_name>” links overlap with the elements from the “Vulnerable Password”/”Breached Website” notification when the browser is resized

Categories

(Firefox :: about:logins, defect, P3)

Product:
Firefox
Component:
about:logins
Platform:
Desktop
All
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 76
Tracking Flags:
Tracking Status
firefox76 --- verified

People

(Reporter: srosu, Assigned: jaws)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

VulnerablePassword_Resize.gif
(deleted), image/gif
Details
Bug 1625967 - Add a minimum width for the login-item container and add media queries that will reduce the login-list width and the padding of the login-item when the browser is narrower to fit more content on small screens. r?sfoster
(deleted), text/x-phabricator-request
Details
Attached image VulnerablePassword_Resize.gif (deleted) —

[Affected versions]:

  • Firefox Nightly 76.0a1 (Build ID: 20200330094747)

[Affected Platforms]:

  • Windows 10 x64
  • Mac 10.14.6
  • Ubuntu 18.04 x64

[Prerequisites]:

  • Have a profile with at least 3 saved logins in which one is vulnerable.

[Steps to reproduce]:

  1. Open the Firefox browser with the profile from prerequisites.
  2. Select a vulnerable login.
  3. Resize the browser to less than 50% and observe the link from the “Vulnerable Password” notification.

[Expected result]:

  • The “Learn more” and the “Go to <website_name>” links are correctly displayed and rendered.

[Actual result]:

  • The “Learn more” and the “Go to <website_name>” links overlap with the elements from the notification.

[Notes]:

  • Attached a screen recording with the issue.
Priority: -- → P3
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Attachment #9136916 - Attachment description: Bug 1625967 - Add a minimum width for the login-item container and add media queries that will reduce the login-list width and the padding of the login-item when the browser is narrower to fit more content on small screens. → Bug 1625967 - Add a minimum width for the login-item container and add media queries that will reduce the login-list width and the padding of the login-item when the browser is narrower to fit more content on small screens. r?sfoster
Flags: qe-verify+
Pushed by jwein@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/19ca295a5c79 Add a minimum width for the login-item container and add media queries that will reduce the login-list width and the padding of the login-item when the browser is narrower to fit more content on small screens. r=sfoster

https://hg.mozilla.org/mozilla-central/rev/19ca295a5c79

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox76: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 76
Regressions: 1626892

I have verified this issue using the latest Nightly 76.0a1 (Build ID: 20200401212659) on Windows 10 x64, Mac 10.14, Ubuntu 18.04 x64.

  • The “Learn more” and the “Go to <website_name>” links are not overlapping anymore with the elements from the “Vulnerable Password”/”Breached Website” notification when the browser is resized.
  • While verifying this I have encountered a new behavior which was introduced by this fix. The elements of a login item are cropped if the browser window is resized.
  • I have logged a different bug for this new behavior Bug 1626892.
  • Considering this I’ll mark this issue as Verified fixed.
Status: RESOLVED → VERIFIED
status-firefox76: fixed → verified
Flags: qe-verify+
No longer regressions: 1626892
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: