Closed Bug 1626015 Opened 5 years ago Closed 4 years ago

Implement ParentNode#replaceChildren

Categories

(Core :: DOM: Core & HTML, enhancement, P3)

Product:

Component:

Type:

enhancement

Priority:

P3

Severity:

normal

Tracking

()

Status:

RESOLVED FIXED

Milestone:

mozilla78

Tracking Flags:

Tracking

Status

firefox78

---

fixed

People

(Reporter: saschanaz, Assigned: WeirdAl)

References

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

Bug 1626015 - Implement ParentNode#ReplaceChildren. r=emilio 5 years ago Alex Vincent [:WeirdAl] (deleted), text/x-phabricator-request		Details

Kagami [:saschanaz] (they/them, PTO until 2023-09-10)

Reporter

Description

•

5 years ago

See the PR: https://github.com/whatwg/dom/pull/851

Comment 1

•

5 years ago

Thanks for all your work here, I agree this is something we should do!

Priority: -- → P3

Alex Vincent [:WeirdAl]

Assignee

Updated

•

5 years ago

Assignee: nobody → ajvincent

Alex Vincent [:WeirdAl]

Assignee

Comment 2

•

5 years ago

This seems like a reasonable bug to re-familiarize myself with DOM development.

Status: NEW → ASSIGNED

Alex Vincent [:WeirdAl]

Assignee

Comment 3

•

5 years ago

Attached file Bug 1626015 - Implement ParentNode#ReplaceChildren. r=emilio (deleted) — Details

Updated

•

4 years ago

Keywords: dev-doc-needed

Comment 4

•

4 years ago

Pushed by rmaries@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/004abcb3322e Implement ParentNode#ReplaceChildren. r=emilio

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Comment 5

•

4 years ago

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/23803 for changes under testing/web-platform/tests

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Comment 6

•

4 years ago

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 7

•

4 years ago

Backed out for perma failures on idlharness.window.html.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=0e599b4263254c62194891889abb3d6d242a4876&selectedTaskRun=ZKHK0Y8jRv-6AMd2BdNUeA-0

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=304005325&repo=autoland&lineNumber=2967

Backout: https://hg.mozilla.org/integration/autoland/rev/7610307d40316f253efcda42fe5939baf100efb2

Flags: needinfo?(ajvincent)

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Comment 8

•

4 years ago

Upstream PR was closed without merging

Updated

•

4 years ago

Flags: needinfo?(ajvincent)

Updated

•

4 years ago

Flags: needinfo?(ajvincent)

Alex Vincent [:WeirdAl]

Assignee

Comment 9

•

4 years ago

Patch updated on phabricator, additional tests no longer excluded, just needing review before attempting another landing.

Flags: needinfo?(ajvincent)

Alex Vincent [:WeirdAl]

Assignee

Updated

•

4 years ago

Flags: needinfo?(emilio)

Emilio Cobos Álvarez (:emilio)

Updated

•

4 years ago

Flags: needinfo?(emilio)

Comment 10

•

4 years ago

Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a3fcf899da1a Implement ParentNode#ReplaceChildren. r=emilio

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Comment 11

•

4 years ago

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Noemi Erli[:noemi_erli]

Comment 12

•

4 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/a3fcf899da1a

Status: ASSIGNED → RESOLVED

Closed: 4 years ago

status-firefox78: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla78

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Comment 13

•

4 years ago

Upstream PR merged by moz-wptsync-bot

Chris Mills [:cmills]

Comment 14

•

4 years ago

I think I've documented this sufficiently on MDN; see https://github.com/mdn/sprints/issues/3307#issuecomment-638437979 for the full details.

Let me know if you think this needs anything else. Thanks!

Chris Mills [:cmills]

Updated

•

4 years ago

Keywords: dev-doc-needed → dev-doc-complete

Olli Pettay [:smaug][bugs@pettay.fi]

Updated

•

2 years ago

Regressions: 1799354

You need to log in before you can comment on or make changes to this bug.