"./mach static-analysis check" should rely on tools/rewriting/ThirdPartyPaths.txt instead of .clang-format-ignore
Categories
(Developer Infrastructure :: Lint and Formatting, defect, P3)
Tracking
(Not tracked)
People
(Reporter: Sylvestre, Unassigned, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [lang=python])
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
For example, disabling mfbt/lz4/ in tools/rewriting/ThirdPartyPaths.txt isn't enough run the tools on mfbt/lz4/
$ ./mach static-analysis check --checks="-*, readability-else-after-return" --fix mfbt/lz4/lz4.c -v
Defined here:
https://searchfox.org/mozilla-central/source/python/mozbuild/mozbuild/code-analysis/mach_commands.py#2120
Comment 1•5 years ago
|
||
The priority flag is not set for this bug.
:ahal, could you have a look please?
For more information, please visit auto_nag documentation.
Updated•5 years ago
|
Comment 2•5 years ago
|
||
Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is P3
(Backlog,) indicating it has been triaged, the bug's Severity is being updated to S3
(normal.)
The searchfox link for this bug should be:
https://searchfox.org/mozilla-central/source/python/mozbuild/mozbuild/code_analysis/mach_commands.py#2120
The link in the above commend uses a dash instead of an underscore here------^
Also, the specified line of code has moved to:
https://searchfox.org/mozilla-central/source/python/mozbuild/mozbuild/code_analysis/mach_commands.py#188
Does not depend on 111557. That was my mistake when creating the commit and submitting it.
Updated•4 years ago
|
Comment 7•3 years ago
|
||
This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.
Comment 8•3 years ago
|
||
I'd like to work on this.
Comment 9•3 years ago
|
||
Hi there. Someone working on this bug? I would like to work on this bug. Still available to fix?. Thanks
Comment 10•3 years ago
|
||
yes, feel free to work on it, I am assigning it to you. If you have questions, find us in Element in the #test (firefox testing) channel. You might want to look at the previous patch to see what was good and what needed additional work.
Updated•3 years ago
|
Updated•3 years ago
|
Comment 11•3 years ago
|
||
Is this bug open to work? I would like to work if it is.
Updated•2 years ago
|
Description
•