Closed Bug 1627373 Opened 5 years ago Closed 5 years ago

BCE shouldn't have lineno and columno argument, and should instead use the associated FunctionBox::extent()

Categories

(Core :: JavaScript Engine, task, P2)

task

Tracking

()

RESOLVED FIXED
mozilla77
Tracking Status
firefox77 --- fixed

People

(Reporter: mgaudet, Assigned: mgaudet)

References

Details

Attachments

(2 files)

These two pieces of info should be redundant, so we should just use FunctionBox::extent.

Priority: -- → P2
Assignee: nobody → mgaudet
Status: NEW → ASSIGNED

Outside of powering BytecodeSection's source notes generation, the line and
column numbers were almost entirely unused, except to power a single assertion
that lineno and column agreed between the stencil (BCE derived) and script.

However, by switching to using the SharedContext extents, we lose the ability
to always assert they're the same, because in the old system dynamically
allocated functions used externally provided column info that disagrees with
the parser result. In this patch the script still gets the same column
number as before, but we can't assert that the value is the same as what you
could get out of the BCE, because the BCE number is actually more accurate
than the script.

Fixing the script column should be followup.

Depends on D70410

Pushed by mgaudet@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8a404acd3a42 Give shared contexts an extent r=tcampbell https://hg.mozilla.org/integration/autoland/rev/17dadcf8617f Use SharedContext source extents instead of passing around line and columns r=tcampbell

Based on the failures, it looks like something is wrong with how Modules are handled.

Correct; This gave modules a line number of 1, ignoring the line and column of the options.

Corrected I think the remaining oranges on Try are intermittents:https://treeherder.mozilla.org/#/jobs?repo=try&revision=afcdd3de02e413d138386509fa5bb2d0875bd383

Flags: needinfo?(mgaudet)
Pushed by mgaudet@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8e1c3f7241e4 Give shared contexts an extent r=tcampbell https://hg.mozilla.org/integration/autoland/rev/f3d35a537298 Use SharedContext source extents instead of passing around line and columns r=tcampbell
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: