Move pref handling from SearchService to Region.jsm
Categories
(Firefox :: Search, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox78 | --- | fixed |
People
(Reporter: daleharvey, Assigned: daleharvey)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 2 obsolete files)
|
(deleted),
text/x-phabricator-request
|
Details |
|
Assignee | |
Updated•5 years ago
|
|
||
Updated•5 years ago
|
|
|
Assignee | |
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
|
|
Assignee | |
Comment 1•4 years ago
|
||
|
|
Assignee | |
Comment 2•4 years ago
|
||
|
||
Comment 5•4 years ago
|
||
Backed out for causing failures at test_legacy_reload_engines.js
https://hg.mozilla.org/integration/autoland/rev/61e94240dbc789ad4fa39d57ad815b8100159899
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=303933946&repo=autoland&lineNumber=4702
|
|
Assignee | |
Comment 6•4 years ago
|
||
So I was missing a switch to template string in the windows only telemetry code @ https://hg.mozilla.org/integration/autoland/rev/d51495af14ffe118a36d21c5d652bdcf6d4edc6d#l19.179, updated
|
||
Comment 8•4 years ago
|
||
Backed out for perma failures on test_geodefaults.js.
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=303982398&repo=autoland&lineNumber=6991
Backout: https://hg.mozilla.org/integration/autoland/rev/467350d49e377fb463658c910916d4eeb918559c
|
|
Assignee | |
Comment 9•4 years ago
|
||
test_geodefaults has an assumption that maybeReloadEngines wouldnt get triggered which this patch changed, it was timing dependent and quite surprising seems to only happen on windows reasonably often
Pushed fix to https://treeherder.mozilla.org/#/jobs?repo=try&revision=dd07f17ca1aa74c5e900ae73a0af9bce915c3681 and will hopefully get it stick this time if that run is green
|
||
Comment 10•4 years ago
|
||
|
|
||
Comment 13•4 years ago
|
||
| bugherder | ||
|
||
Comment 14•4 years ago
|
||
|
||
Updated•4 years ago
|
|
|
||
Comment 15•4 years ago
|
||
Comment on attachment 9152069 [details]
Bug 1627548 - Update Activity Stream to use new Region.jsm API
Revision D77051 was moved to bug 1627548. Setting attachment 9152069 [details] to obsolete.
|
|
||
Comment 16•4 years ago
|
||
Comment on attachment 9165532 [details]
Bug 1627541 - Adding tests for region observer and region uninit
Revision D84603 was moved to bug 1627548. Setting attachment 9165532 [details] to obsolete.
Description
•