Replace MOZ_MUST_USE with [[nodiscard]] in mozglue/baseprofiler
Categories
(Core :: Gecko Profiler, task, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox77 | --- | fixed |
People
(Reporter: mozbugz, Assigned: mozbugz)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
The MOZ_MUST_USE
macro is defined as clang's and gcc's nonstandard attribute((warn_unused_result))
. Now that we compile as C++17 by default (bug 1560664), we can replace MOZ_MUST_USE
with C++17's standard [[nodiscard]]
attribute.
Also move MOZ_MUST_USE
before function declarations' specifiers and return type. While clang and gcc's attribute((warn_unused_result))
can appear before, between, or after function specifiers and return types, the [[nodiscard]]
attribute must precede the function specifiers.
(Stolen Copied from bug 1627490. I'm currently working on lots of patches in mozglue/baseprofiler, some of which are adding millions of MOZ_MUST_USE
s, so I think it's easier for me to make the changes in current code and WIP patches. Thank you Chris for starting this effort!)
Assignee | ||
Comment 1•5 years ago
|
||
Also move MOZ_MUST_USE before function declarations' specifiers and return type. While clang and gcc's attribute((warn_unused_result)) can appear before, between, or after function specifiers and return types, the [[nodiscard]] attribute must precede the function specifiers.
And removed a few unneded #include "mozilla/Attributes.h"
.
Pushed by gsquelart@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8a9798def63e Replace MOZ_MUST_USE with [[nodiscard]] in mozglue/baseprofiler. r=canaltinova
Comment 3•5 years ago
|
||
bugherder |
Description
•