LoadInfo::LoadingPrincipal should be GetLoadingPrincipal instead.
Categories
(Core :: DOM: Security, task, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox77 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
Details
(Whiteboard: [domsecurity-active])
Attachments
(3 files)
It can return null, so renaming it like that would prevents mistakes.
|
Assignee | |
Comment 1•5 years ago
|
||
Mostly a matter of:
rg -l '->LoadingPrincipal' | xargs sed -i 's/->LoadingPrincipal/->GetLoadingPrincipal/g'
And then clang-format. But I tweaked manually nsHttpChannelAuthProvider (move
the variable where it's used, don't take a useless strong ref),
AddonContentPolicy (move the declaration of the variable to the if condition),
and BackgroundUtils (same).
|
|
Assignee | |
Comment 2•5 years ago
|
||
It's just a nested if which can be written with &&.
Depends on D69828
|
|
Assignee | |
Comment 3•5 years ago
|
||
No need for temporaries, we can just construct the object in place.
Depends on D69829
|
||
Updated•5 years ago
|
|
||
Comment 6•5 years ago
|
||
Backed out for causing several test failures:
Failure logs: https://treeherder.mozilla.org/logviewer.html#?job_id=296450468&repo=autoland
https://treeherder.mozilla.org/logviewer.html#?job_id=296449666&repo=autoland
https://treeherder.mozilla.org/logviewer.html#?job_id=296450470&repo=autoland
https://treeherder.mozilla.org/logviewer.html#?job_id=296450532&repo=autoland
https://treeherder.mozilla.org/logviewer.html#?job_id=296450527&repo=autoland
https://treeherder.mozilla.org/logviewer.html#?job_id=296449819&repo=autoland
Backout link: https://hg.mozilla.org/integration/autoland/rev/403e503a4a84
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
|
Assignee | |
Updated•5 years ago
|
|
||
Comment 8•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/711bb3721f0d
https://hg.mozilla.org/mozilla-central/rev/1e6c40ef6b87
https://hg.mozilla.org/mozilla-central/rev/7044929ad879
Description
•