Closed Bug 1627816 Opened 5 years ago Closed 5 years ago

Picture cache does not invalidate when clipped content is hidden

Categories

(Core :: Graphics: WebRender, defect, P2)

defect

Tracking

()

VERIFIED FIXED
mozilla77
Tracking Status
firefox-esr68 --- unaffected
firefox74 --- wontfix
firefox75 --- wontfix
firefox76 --- wontfix
firefox77 --- verified

People

(Reporter: mikokm, Assigned: gw)

References

(Regression)

Details

(Keywords: regression, testcase)

Attachments

(3 files)

Attached file mask-dynamic-visibility-1.html (deleted) —

The attached testcase dynamically changes the visibility of the masked content.
When picture caching is enabled, the hidden element remains on the screen until repaint is triggered.

Flags: needinfo?(gwatson)
Priority: -- → P3
Summary: Picture cache does not invalidate when mask content changes → Picture cache does not invalidate when clipped content is hidden
Attached file clip-dynamic-visibility-1.html (deleted) —

This also happens with simple clipping.

Blocks: wr-76
Priority: P3 → P2
Assignee: nobody → gwatson
Flags: needinfo?(gwatson)

This fixes a case where the backing surface of a picture cache tile
changes, but was still being considered a no-op frame, which skips
the composite as an optimization if nothing has changed.

In this case, the tile surface changes from a rasterized texture
to a solid color that doesn't require a picture cache texture.

The patch ensures that the composite surface descriptors that are
used to detect no-op frame compositions include the backing
surface for each of the tiles that make up this virtual surface.

Pushed by gwatson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5b784c47235c Fix skipping composites when tile surface changes. r=nical
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77

The patch landed in nightly and beta is affected.
:gw, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(gwatson)

I don't think it's likely to be hit in real web content, so we probably don't need to uplift this to beta.

Miko, do you think we need to uplift the fix for this to beta?

Flags: needinfo?(gwatson) → needinfo?(mikokm)

(In reply to Glenn Watson [:gw] from comment #7)

I don't think it's likely to be hit in real web content, so we probably don't need to uplift this to beta.

Miko, do you think we need to uplift the fix for this to beta?

I would expect the overflow clipping case to be somewhat common, but since most user interactions trigger a repaint, it probably won't be noticeable.

Flags: needinfo?(mikokm)

Sounds like a wontfix in that case.

Flags: qe-verify+

Reproduced the issue using Firefox 77.0a1 (20200407214402) on Windows 10x64 and the attached test cases from comment 0 and comment 1.
The issue is verified fixed with Firefox 77.0b7 (20200515125749) on Windows 10x64.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: