Picture cache does not invalidate when clipped content is hidden
Categories
(Core :: Graphics: WebRender, defect, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr68 | --- | unaffected |
firefox74 | --- | wontfix |
firefox75 | --- | wontfix |
firefox76 | --- | wontfix |
firefox77 | --- | verified |
People
(Reporter: mikokm, Assigned: gw)
References
(Regression)
Details
(Keywords: regression, testcase)
Attachments
(3 files)
The attached testcase dynamically changes the visibility of the masked content.
When picture caching is enabled, the hidden element remains on the screen until repaint is triggered.
Updated•5 years ago
|
Reporter | ||
Updated•5 years ago
|
Reporter | ||
Comment 1•5 years ago
|
||
This also happens with simple clipping.
Reporter | ||
Comment 2•5 years ago
|
||
Regression range: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=1330041fa8973ac2a56f074a7c1eee9bb1cff151&tochange=93ccc760c4dd69f63d6ac171ace357b0dd31412a
Regressed by bug 1599965 or bug 1599656, possibly both.
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 3•5 years ago
|
||
This fixes a case where the backing surface of a picture cache tile
changes, but was still being considered a no-op frame, which skips
the composite as an optimization if nothing has changed.
In this case, the tile surface changes from a rasterized texture
to a solid color that doesn't require a picture cache texture.
The patch ensures that the composite surface descriptors that are
used to detect no-op frame compositions include the backing
surface for each of the tiles that make up this virtual surface.
Comment 5•5 years ago
|
||
bugherder |
Updated•5 years ago
|
Comment 6•5 years ago
|
||
The patch landed in nightly and beta is affected.
:gw, is this bug important enough to require an uplift?
If not please set status_beta
to wontfix
.
For more information, please visit auto_nag documentation.
Assignee | ||
Comment 7•5 years ago
|
||
I don't think it's likely to be hit in real web content, so we probably don't need to uplift this to beta.
Miko, do you think we need to uplift the fix for this to beta?
Reporter | ||
Comment 8•5 years ago
|
||
(In reply to Glenn Watson [:gw] from comment #7)
I don't think it's likely to be hit in real web content, so we probably don't need to uplift this to beta.
Miko, do you think we need to uplift the fix for this to beta?
I would expect the overflow clipping case to be somewhat common, but since most user interactions trigger a repaint, it probably won't be noticeable.
Comment 9•5 years ago
|
||
Sounds like a wontfix in that case.
Updated•4 years ago
|
Comment 10•4 years ago
|
||
Description
•