Closed Bug 1627864 Opened 5 years ago Closed 5 years ago

Fix invalidation of tiles when the shape of the spatial node tree changes

Categories

(Core :: Graphics: WebRender, task)

task
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla77
Tracking Status
firefox77 --- fixed

People

(Reporter: gw, Assigned: gw)

References

Details

Attachments

(1 file)

No description provided.

Previously, primitive dependency checking would invalidate a tile if
the spatial node index for a given primitive changed.

However, if a new display list is sent that changes the shape of
the spatial node tree this may cause unnecessary invalidations.

For example, a new display list that inserts a new spatial node at
the start of the tree could result in spatial node indices being
different, even though the values of the transforms was the same.

This patch changes the invalidation logic for spatial nodes to
compare the transforms by value, rather than index, meaning that
invalidations are avoided if the shape of the spatial tree has
changed, but the values are consistent.

Assignee: nobody → gwatson
Status: NEW → ASSIGNED
Blocks: 1576637
Pushed by gwatson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/498d2204d637 Fix invalidation of tiles when the shape of the spatial node tree changes. r=nical,Bert,kvark
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: