Closed Bug 1628153 Opened 5 years ago Closed 5 years ago

Firefox 75+ isn't enforcing >=libvpx-1.8.0 requirement

Categories

(Core :: WebRTC: Audio/Video, defect)

Product:
Core
Component:
WebRTC: Audio/Video
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla77
Tracking Flags:
Tracking Status
firefox77 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1628153 - Require libvpx >= 1.8.0.
(deleted), text/x-phabricator-request
Details

This is similar to bug 1523611, but for 1.8.0, after bug 1525393

/build/firefox-75.0/media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc: In member function 'int webrtc::VP9EncoderImpl::InitAndSetControlSettings(const webrtc::VideoCodec*)':
/build/firefox-75.0/media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc:447:7: error: 'vpx_svc_frame_drop_t' was not declared in this scope
       vpx_svc_frame_drop_t svc_drop_frame;
       ^~~~~~~~~~~~~~~~~~~~
/build/firefox-75.0/media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc:447:7: note: suggested alternative: 'vpx_enc_frame_flags_t'
       vpx_svc_frame_drop_t svc_drop_frame;
       ^~~~~~~~~~~~~~~~~~~~
       vpx_enc_frame_flags_t
/build/firefox-75.0/media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc:448:7: error: 'svc_drop_frame' was not declared in this scope
       svc_drop_frame.framedrop_mode = CONSTRAINED_LAYER_DROP;
       ^~~~~~~~~~~~~~
/build/firefox-75.0/media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc:448:7: note: suggested alternative: 'vp9_ref_frame'
       svc_drop_frame.framedrop_mode = CONSTRAINED_LAYER_DROP;
       ^~~~~~~~~~~~~~
       vp9_ref_frame
/build/firefox-75.0/media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc:448:39: error: 'CONSTRAINED_LAYER_DROP' was not declared in this scope
       svc_drop_frame.framedrop_mode = CONSTRAINED_LAYER_DROP;
                                       ^~~~~~~~~~~~~~~~~~~~~~

etc.

The required definition were added in v1.8.0

Summary: Firefox 65+ isn't enforcing >=libvpx-1.8.0 requirement → Firefox 75+ isn't enforcing >=libvpx-1.8.0 requirement
Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/37ca1e514865 Require libvpx >= 1.8.0. r=dminor

https://hg.mozilla.org/mozilla-central/rev/37ca1e514865

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox77: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
Has Regression Range: --- → yes
Keywords: regression
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: