User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

1. Open Orca screen reader, and enable "Speak object under mouse" (orca -s, and then in the General tab, under the Mouse section, enable that checkbox).
2. Open a new Firefox window
3. Hover the "New tab" button, next to the default tab.

Actual results:

Orca announces "Push button" (the type of the element)

Expected results:

Orca should have announced something more specific, like "New tab Push button"

Apparently the problem is that the button does not have a label (and so the screen reader doesn't have any text to present). Interestingly enough, the button that is used when there are too many tabs to fit (and thus the scroll buttons and the "all tabs" button appear) work well: it properly announces "New tab Push button". And it does have a label="&tabCmd.label;" from what I see.

Moving this to the tabbed browser component in Firefox front-end. I can confirm this bug on both Windows and OS X as well. Gijs, there seems to be a difference in buttons when there are only a few versus many tabs open. Can you or someone on your team take a look? Should be an easy fix since there is already a string for that that is used for the working case.

Is this a regression?

I'm not sure I have cycles to look into this right now, and I don't "have" a team, unfortunately. I'd like to understand what's going on here though - I would have expected the a11y tests to pick up any changes here.

(In reply to :Gijs (he/him) from comment #2)

Is this a regression?

As I know, this is not a regression. I have the same issue with Firefox 60 on Debian. Compared from Google Chrome, this is a regression because the new tab button is correctly labelled there.

As I know, this is not a regression.

Really? For me on 68.6.0esr the same button has the name "Open a new tab (Ctrl+T)" -- which is kind of a weird name, but it has one.

So for me this is a regression from 68, but maybe 60 had the bug, and it got fixed, and broken again?

Gijs, I don't think this is a regression, I think I saw it once before when I had a new window open with only 1 or 2 tabs, and looked in the a11y tree for something else. And no, I don't believe a11y tests are testing for such front-end labeling extensively yet, so it is very possible that, even if this regressed, they would not have picked it up.

So I believe this has been with us longer, maybe got fixed at some point for the button that is used when there are overflow-tabs, but not for the case where there are not.

(In reply to Colomban Wendling from comment #4)

As I know, this is not a regression.

Really? For me on 68.6.0esr the same button has the name "Open a new tab (Ctrl+T)" -- which is kind of a weird name, but it has one.

OK, my bad. All my tests was on Nightly. Indeed, with Firefox 68 it works.

Mozregression gives me this:
10:12.15 INFO: Last good revision: 8f72a3e136c8e9c27133e4d9b35a135005c984e4
10:12.15 INFO: First bad revision: b00c70075119601d370255e5962eb62429d2cf95

INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=8f72a3e136c8e9c27133e4d9b35a135005c984e4&tochange=b00c70075119601d370255e5962eb62429d2cf95

Looks like it's a regression from bug 1317138.

Right, looking at the patch, that makes sense. Thanks for finding the window!

https://hg.mozilla.org/mozilla-central/rev/0b2eb65093a4

The patch landed in nightly and beta is affected.
:dao, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

There's indeed a label now, thanks!

However, the AT label is not the same on both buttons:

• the tabs-newtab-button button (which got fixed here) has accessible label "Open a new tab (Ctrl+T)"
• the other one (when there are many tabs) has accessible label "New tab"

I'm not sure how much this matters, but it's quite inconsistent and might be worth improving I guess.

(In reply to Colomban Wendling from comment #14)

There's indeed a label now, thanks!

I'll mark this as verified based on this. Thanks.

However, the AT label is not the same on both buttons:

• the tabs-newtab-button button (which got fixed here) has accessible label "Open a new tab (Ctrl+T)"
• the other one (when there are many tabs) has accessible label "New tab"

I'm not sure how much this matters, but it's quite inconsistent and might be worth improving I guess.

Feel free to file a bug on this.

Comment on attachment 9139482 [details]
Bug 1628360 - Set aria-label on tabs-newtab-button. r=gijs

Beta/Release Uplift Approval Request

• User impact if declined: see comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial fix
• String changes made/needed:

Comment on attachment 9139482 [details]
Bug 1628360 - Set aria-label on tabs-newtab-button. r=gijs

Simple a11y fix, approved for 76.0b5.

https://hg.mozilla.org/releases/mozilla-beta/rev/b2e4e121ecaf