harishd Reporter
	Description • 25 years ago

#1. To reproduce the crash do the following.

1. Open up editor and select the contents ( completely ) of the
   opening document ( initial editor test document ).
2. Now do Ctrl-C twice ( this is also a bug ).

You should see a crash in

void nsHTMLContentSinkStream::EnsureBufferSize(PRInt32 aNewSize)
{
  if (mBufferSize < aNewSize)       <----- mBuffSize = 3 and aNewSize = 4
  {
    delete [] mBuffer;              <----- mBuffer had a string value "hr"

....

Unable to provide the stack because the crash happend when my copy-buffer was in
use and therefore wasn't able to attach the stack to the report.

#2. There is no code to delete mBuffer in nsHTMLContentSinkStream destructor.

	Kathleen :Brade
	Comment 1 • 25 years ago

reassign to akkana@netscape.com

Sujay--can you reproduce this bug on any other platforms?

	sujay
	Comment 2 • 25 years ago

I can't reproduce this...but now we don't load the initial
editor test page so I tried it out on a bare minimum loaded
page with text...Harish, is this still happening for you?

	harishd Reporter
	Comment 4 • 25 years ago

Yes, it still crashes for me.

	Akkana Peck Assignee
	Comment 5 • 25 years ago

I'm not seeing this on Linux, but there are known problems with Windows
copy/paste, and perhaps the crash is related to that.  But I'll keep this at
least 'til I fix the problem with not deleting the buffer.

	Akkana Peck Assignee
	Comment 6 • 25 years ago

Cc'ing Pinkerton -- this only happens on windows, and it's possible that it's
resulting from memory corruption from problems in the Windows clipboard code.

	Akkana Peck Assignee
	Comment 7 • 25 years ago

Adding Rick to cc list -- Rick, if you find yourself doing a Windows Purify run
looking at the parser library, we'd love to know what happens when you hit ^C
twice after selecting all the text in the document.

	Akkana Peck Assignee
	Comment 8 • 25 years ago

Harish just checked in a fix for this.

	harishd Reporter
	Comment 9 • 25 years ago

Tree is red. I haven't checked in the fix yet.  Will checkin as soon as the tree
turns green.

I'll close the bug after my checkin.

	harishd Reporter
	Comment 10 • 25 years ago

Ok, fix is in...  Marking bug FIXED.

	sujay
	Comment 11 • 25 years ago

verified in 10/21 build.

	harishd Reporter
	Comment 12 • 25 years ago

Akkana, I'm reopening this bug because the crash started to happen again. We
expected this...didn't we??

	Akkana Peck Assignee
	Comment 13 • 25 years ago

I hope to check in the encoder fix I've been working on with Naoki today.  That
changes the code and should be a bit more reliable; with any luck it'll fix this
problem too.

	harishd Reporter
	Comment 14 • 25 years ago

Not crashing anymore ( tested with akkana's recent changes ).

Marking but FIXED.

	sujay
	Comment 15 • 25 years ago

verified in 11/4 build.