Closed
Bug 162858
Opened 22 years ago
Closed 22 years ago
Correct icon not used for E-mail on XP start menu
Categories
(SeaMonkey :: Installer, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla1.2beta
People
(Reporter: m, Assigned: malcolm-bmo)
References
Details
Attachments
(1 file)
(deleted),
patch
|
dveditz
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
From Bugzilla Helper: User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.1) Gecko/20020814 BuildID: 2002081419 The installer wizard for this build does not set the E-mail icon correctly at the top-left of XP's start menu. This is (presumably) due to a typo. The following registry key *should* have been set: HKEY_LOCAL_MACHINE\SOFTWARE\Clients\Mail\Mozilla\DefaultIcon\(Default) But the typo means that DefaultIcon came out as "DefaultsIcon" (which is ignored by XP). Since I was upgrading Mozilla, the old DefaultIcon entry was left intact (i.e. the first icon in MOZILLA.EXE). Reproducible: Didn't try
Assignee | ||
Comment 1•22 years ago
|
||
That would be here: http://lxr.mozilla.org/seamonkey/source/xpinstall/packager/windows/mail.jst#232 and here: http://lxr.mozilla.org/seamonkey/source/xpinstall/packager/windows/mail.jst#245
Assignee | ||
Comment 2•22 years ago
|
||
Assignee | ||
Comment 3•22 years ago
|
||
cc'ing dprice for review (original reviewer in bug 158187). What happens if we don't have a DefaultIcon subkey? Does XP display the generic Mozilla icon, or something worse?
Assignee | ||
Updated•22 years ago
|
Keywords: mozilla1.1,
patch
Reporter | ||
Comment 4•22 years ago
|
||
If there is no DefaultIcon subkey, you are correct in saying that the default Mozilla icon (red lizard) is displayed.
Comment 5•22 years ago
|
||
Renaming the registry key from DefaultsIcon to DefaultIcon immediately corrects the problem. I haven't verified if the patch does this, but I do know this will correct the problem.
Assignee | ||
Comment 7•22 years ago
|
||
Requsting r=/sr= for this trivial typo patch. We didn't get this into 1.1. It would be nice to fix it at some point.
Assignee: dveditz → bugzilla2
Assignee | ||
Updated•22 years ago
|
Comment 8•22 years ago
|
||
dupe of the famouse icon meta bug... *** This bug has been marked as a duplicate of 28174 ***
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → DUPLICATE
Reporter | ||
Comment 9•22 years ago
|
||
Henrik Gemal - please explain why this is a duplicate of bug 28174. That bug is about a dialog box to specify where icons are created. This bug (which has a patch ready!) is about a typo in the Installer when creating a registry entry.
Assignee | ||
Comment 10•22 years ago
|
||
What the other Malcolm said. This isn't remotely about the shortcut select dialog, it's a typo fix in existing installer code. Reopening. Sorry Henrik, you goofed here.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Assignee | ||
Updated•22 years ago
|
Status: REOPENED → ASSIGNED
Comment 11•22 years ago
|
||
sorry about that. this is not a dupe. the fix is trivial and should land asap.... Dan: perhaps you could r or sr this simple patch?
Comment on attachment 95419 [details] [diff] [review] Patch (not tested) sr=roc+moz send email to dveditz@netscape.com to get a review.
Attachment #95419 -
Flags: superreview+
Comment 14•22 years ago
|
||
Comment on attachment 95419 [details] [diff] [review] Patch (not tested) r=dveditz
Attachment #95419 -
Flags: review+
Assignee | ||
Comment 17•22 years ago
|
||
caillon checked this in. Marking FIXED.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago → 22 years ago
Resolution: --- → FIXED
Comment 18•22 years ago
|
||
verified on 11/12 build
Status: RESOLVED → VERIFIED
QA Contact: bugzilla → gbush
Comment 19•21 years ago
|
||
Is it just me (on both of my computes), or does the Mozilla Mail icon on the Start menu now default to the red lizard head with the triangular thing (the exact same one used for the browser)? (For anyone new to this bug: I'm talking about the icon that shows on the Windows XP Start menu when Mozilla Mail is selected as the program to be displayed on the Internet/Mail section at the top.) This should be a simple fix: instead of setting HKEY_LOCAL_MACHINE\SOFTWARE\Clients\Mail\Mozilla\DefaultIcon to "<Install Path>\mozilla.exe,0" (or whatever it is now) , set it to "<Install Path>\chrome\icons\default\messengerWindow.ico". This is the only bug I could find that's related; I wanted to see if it's an issue for anyone else before--if need be--filing a new bug.
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•