Closed Bug 1628692 Opened 5 years ago Closed 4 years ago

FallibleTArray must not be copy-constructible/copy-assignable

Tracking

()

Status:

RESOLVED FIXED

Milestone:

mozilla77

Tracking Flags:

Tracking

Status

firefox77

---

fixed

People

(Reporter: sg, Assigned: sg)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

Attachments

(11 files)

Bug 1628692 - Make Sequence infallibly copyable for now. r=smaug 5 years ago Simon Giesecke [:sg] [he/him] (deleted), text/x-phabricator-request		Details
Bug 1628692 - Fix FallibleTArray handling in gfxContext::CurrentDash. r=jrmuizel 5 years ago Simon Giesecke [:sg] [he/him] (deleted), text/x-phabricator-request		Details
Bug 1628692 - Make FallibleTArray uncopyable. r=#xpcom-reviewers 5 years ago Simon Giesecke [:sg] [he/him] (deleted), text/x-phabricator-request		Details
Bug 1628692 - Prepare dom/serviceworkers and dom/workers for making FallibleTArray uncopyable. r=#dom-workers-and-storage 4 years ago Simon Giesecke [:sg] [he/him] (deleted), text/x-phabricator-request		Details
Bug 1628692 - Prepare dom/crypto for making FallibleTArray uncopyable. r=keeler 4 years ago Simon Giesecke [:sg] [he/him] (deleted), text/x-phabricator-request		Details
Bug 1628692 - Prepare toolkit/components/url-classifier/ for making FallibleTArray uncopyable. r=gcp 4 years ago Simon Giesecke [:sg] [he/him] (deleted), text/x-phabricator-request		Details
Bug 1628692 - Prepare media/webrtc/signaling/src/peerconnection/ for making FallibleTArray uncopyable. r=jesup 4 years ago Simon Giesecke [:sg] [he/him] (deleted), text/x-phabricator-request		Details
Bug 1628692 - Prepare dom/webauthn for making FallibleTArray uncopyable. r=jcj 4 years ago Simon Giesecke [:sg] [he/him] (deleted), text/x-phabricator-request		Details
Bug 1628692 - Prepare dom/media for making FallibleTArray uncopyable. r=jya 4 years ago Simon Giesecke [:sg] [he/him] (deleted), text/x-phabricator-request		Details
Bug 1628692 - Prepare dom/filesystem for making FallibleTArray uncopyable. r=smaug 4 years ago Simon Giesecke [:sg] [he/him] (deleted), text/x-phabricator-request		Details
Bug 1628692 - Prepare dom/base for making FallibleTArray uncopyable. r=smaug 4 years ago Simon Giesecke [:sg] [he/him] (deleted), text/x-phabricator-request		Details

Simon Giesecke [:sg] [he/him]

Assignee

Description

•

5 years ago

FallibleTArray must not be copy-constructible or copy-assignable. These operations may fail, but there's no way to signal this to the caller. Instead, named member functions with a fallible_t argument must be used instead to make the copy.

There are several uses of this, including in code generated by ipdlc, which must be fixed first or as part of this.

Simon Giesecke [:sg] [he/him]

Assignee

Updated

•

5 years ago

Component: MFBT → XPCOM

Simon Giesecke [:sg] [he/him]

Assignee

Updated

•

5 years ago

Depends on: 1631435

Simon Giesecke [:sg] [he/him]

Assignee

Updated

•

5 years ago

See Also: → https://bugzilla.mozilla.org/show_bug.cgi?id=1628715

Simon Giesecke [:sg] [he/him]

Assignee

Updated

•

5 years ago

Blocks: 1631461

Simon Giesecke [:sg] [he/him]

Assignee

Comment 1

•

5 years ago

Attached file Bug 1628692 - Make Sequence infallibly copyable for now. r=smaug (deleted) — Details

Phabricator Automation

Updated

•

5 years ago

Assignee: nobody → sgiesecke

Status: NEW → ASSIGNED

Simon Giesecke [:sg] [he/him]

Assignee

Comment 2

•

5 years ago

Attached file Bug 1628692 - Fix FallibleTArray handling in gfxContext::CurrentDash. r=jrmuizel (deleted) — Details

Depends on D71574

Simon Giesecke [:sg] [he/him]

Assignee

Comment 3

•

5 years ago

Attached file Bug 1628692 - Make FallibleTArray uncopyable. r=#xpcom-reviewers (deleted) — Details

Depends on D71576

Phabricator Automation

Updated

•

5 years ago

Attachment #9141724 - Attachment description: Bug 1628692 - Make Sequence copyable for now. r=smaug → Bug 1628692 - Make Sequence infallibly copyable for now. r=smaug

Simon Giesecke [:sg] [he/him]

Assignee

Comment 4

•

4 years ago

Attached file Bug 1628692 - Prepare dom/serviceworkers and dom/workers for making FallibleTArray uncopyable. r=#dom-workers-and-storage (deleted) — Details

Depends on D71576

Simon Giesecke [:sg] [he/him]

Assignee

Comment 5

•

4 years ago

Attached file Bug 1628692 - Prepare dom/crypto for making FallibleTArray uncopyable. r=keeler (deleted) — Details

Depends on D72618

Simon Giesecke [:sg] [he/him]

Assignee

Comment 6

•

4 years ago

Attached file Bug 1628692 - Prepare toolkit/components/url-classifier/ for making FallibleTArray uncopyable. r=gcp (deleted) — Details

Depends on D72619

Simon Giesecke [:sg] [he/him]

Assignee

Comment 7

•

4 years ago

Attached file Bug 1628692 - Prepare media/webrtc/signaling/src/peerconnection/ for making FallibleTArray uncopyable. r=jesup (deleted) — Details

Depends on D72620

Simon Giesecke [:sg] [he/him]

Assignee

Comment 8

•

4 years ago

Attached file Bug 1628692 - Prepare dom/webauthn for making FallibleTArray uncopyable. r=jcj (deleted) — Details

Depends on D72621

Simon Giesecke [:sg] [he/him]

Assignee

Comment 9

•

4 years ago

Attached file Bug 1628692 - Prepare dom/media for making FallibleTArray uncopyable. r=jya (deleted) — Details

Depends on D72622

Simon Giesecke [:sg] [he/him]

Assignee

Comment 10

•

4 years ago

Attached file Bug 1628692 - Prepare dom/filesystem for making FallibleTArray uncopyable. r=smaug (deleted) — Details

Depends on D72623

Simon Giesecke [:sg] [he/him]

Assignee

Comment 11

•

4 years ago

Attached file Bug 1628692 - Prepare dom/base for making FallibleTArray uncopyable. r=smaug (deleted) — Details

Depends on D72624

Pulsebot

Comment 12

•

4 years ago

Pushed by sgiesecke@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/624e19601244 Make Sequence infallibly copyable for now. r=smaug https://hg.mozilla.org/integration/autoland/rev/187234687039 Fix FallibleTArray handling in gfxContext::CurrentDash. r=jrmuizel https://hg.mozilla.org/integration/autoland/rev/71e08c8c8989 Prepare dom/serviceworkers and dom/workers for making FallibleTArray uncopyable. r=dom-workers-and-storage-reviewers,edenchuang https://hg.mozilla.org/integration/autoland/rev/5b584b2a5d4f Prepare dom/crypto for making FallibleTArray uncopyable. r=keeler https://hg.mozilla.org/integration/autoland/rev/a1490f1af74c Prepare toolkit/components/url-classifier/ for making FallibleTArray uncopyable. r=gcp https://hg.mozilla.org/integration/autoland/rev/d0842e4533ad Prepare media/webrtc/signaling/src/peerconnection/ for making FallibleTArray uncopyable. r=jesup,bwc,erahm https://hg.mozilla.org/integration/autoland/rev/1902866d724e Prepare dom/webauthn for making FallibleTArray uncopyable. r=jcj https://hg.mozilla.org/integration/autoland/rev/c32bca788054 Prepare dom/media for making FallibleTArray uncopyable. r=jya https://hg.mozilla.org/integration/autoland/rev/b0a71249d010 Prepare dom/filesystem for making FallibleTArray uncopyable. r=smaug https://hg.mozilla.org/integration/autoland/rev/d09196735d07 Prepare dom/base for making FallibleTArray uncopyable. r=smaug https://hg.mozilla.org/integration/autoland/rev/fa00c3d74a98 Make FallibleTArray uncopyable. r=xpcom-reviewers,nika

Alexandru Michis [:malexandru]

Comment 13

•

4 years ago

bugherder

Status: ASSIGNED → RESOLVED

Closed: 4 years ago

status-firefox77: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla77

You need to log in before you can comment on or make changes to this bug.