Closed Bug 1628731 Opened 5 years ago Closed 5 years ago

Address bar looks focused despite not having focus when restarting Firefox and opening new windows

Categories

(Firefox :: Address Bar, defect, P1)

Product:
Firefox
Component:
Address Bar
Version:
77 Branch
Type:
defect
Points:
2

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 77
Iteration:
77.1 - Apr 6 - Apr 19
Tracking Flags:
Tracking Status
firefox-esr68 --- unaffected
firefox74 --- unaffected
firefox75 --- unaffected
firefox76 --- unaffected
firefox77 blocking verified

People

(Reporter: verdi, Assigned: dao)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1628731 - Reinstate shouldRemoveFocusedAttribute hack. r=mak
(deleted), text/x-phabricator-request
Details

Happens in Nightly 77.0a1 (2020-04-09) (64-bit)
STR:

  1. Enable session restore
  2. Open a website. Make sure the address bar is not focused.
  3. Restart Firefox
  4. The address bar will be focused and will not lose focus when clicking on the document or the chrome. In order to get it to lose focus, you have to click into the address bar and then click outside.

Expected result:
After a restart the address bar should return to the state it was in when Firefox closed.

I suspect I broke this.

Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Iteration: --- → 77.1 - Apr 6 - Apr 19
Points: --- → 2
Keywords: regression
Priority: -- → P1
Regressed by: 1627969
Has Regression Range: --- → yes
Blocks: urlbar-update-1
Summary: Address bar of current tab becomes focused when restarting Firefox → Address bar looks focused despite not having focus when restarting Firefox
Summary: Address bar looks focused despite not having focus when restarting Firefox → Address bar looks focused despite not having focus when restarting Firefox and opening new windows

This bug is tracked by a release manager but with a small severity so change it to major.
For more information, please visit auto_nag documentation.

Severity: normal → major
Blocks: 1629956
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f9bb93fc9daf Reinstate shouldRemoveFocusedAttribute hack. r=mak

https://hg.mozilla.org/mozilla-central/rev/f9bb93fc9daf

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox77: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 77

This was marked as fixed 2 days ago, but the current nightly still has the problem. Has the patch made it into current builds? If so, it's not fixed. And if not, why was it marked fixed?

(In reply to David Smith from comment #16)

This was marked as fixed 2 days ago, but the current nightly still has the problem.

I'm not seeing it.

Has the patch made it into current builds?

Yes.

I have managed to reproduce this issue using Firefox 77.0a1 (BuildId:20200410213700) on Windows 10 64bit.

This issue is verified fixed using Firefox 77.0b7 (BuildId:20200515125749) on Windows 10 64bit, macOS 10.14 and Ubuntu 18.04 64bit.

Status: RESOLVED → VERIFIED
status-firefox77: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: