Avoid needing to use clang-cl.exe under wine for MIDL
Categories
(Firefox Build System :: General, enhancement, P3)
Tracking
(firefox98 fixed)
| Tracking | Status | |
|---|---|---|
| firefox98 | --- | fixed |
People
(Reporter: away, Assigned: glandium)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
Continuing from https://phabricator.services.mozilla.com/D70254:
A potential further followup might be: what if we get rid of the need for clang-cl.exe? MIDL could either use cl.exe to preprocess, or we could do our own preprocessing and pass /no_cpp. Then the "boring" cross builds (no PGO or sanitizers) could use the regular linux64-clang-9 toolchain. What do you think?
|
||
Updated•5 years ago
|
|
Assignee | |
Comment 1•3 years ago
|
||
This avoids needing clang-cl.exe on cross compilations. We could keep
Windows builds on having MIDL do the preprocessing, but that would be
a difference between native and cross builds, and it's better to avoid
that.
|
||
Updated•3 years ago
|
|
|
Assignee | |
Comment 2•3 years ago
|
||
|
|
Assignee | |
Comment 3•3 years ago
|
||
We don't need clang-cl.exe from the win-cross toolchain anymore, which
makes the remaining usecase for that toolchain to provide compiler
runtimes for e.g. asan or profiling. For any build that doesn't involve
those, we can use the plain clang toolchain.
|
||
Updated•3 years ago
|
|
||
Comment 5•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/f18120daf6e4
https://hg.mozilla.org/mozilla-central/rev/e6bda575103e
https://hg.mozilla.org/mozilla-central/rev/19b2d7c75eca
Description
•