Closed
Bug 1629350
Opened 5 years ago
Closed 5 years ago
startup warning: NS_ENSURE_TRUE(mPresShell) failed
Categories
(Core :: Layout, defect, P3)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla77
| Tracking | Status | |
|---|---|---|
| firefox77 | --- | fixed |
People
(Reporter: heycam, Assigned: heycam)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
There is a warning on startup in builds with MOZ_WAYLAND defined:
WARNING: NS_ENSURE_TRUE(mPresShell) failed: file /z/moz/l/layout/base/nsPresContext.cpp, line 844
This happens when under nsPresContext::Init, when the newly created refresh driver attempts to call into GetRootWidget() here:
At this point, the pres context doesn't have a pres shell.
The widget-specific vsync stuff was added in bug 1542808. The warning only seems to fire in content processes, so I want to null check the pres shell to avoid the warning.
|
Assignee | |
Comment 1•5 years ago
|
||
This tends to happen in content processes only, but per the commit
message from bug 1542808, we don't provide a widget-specific vsync
source in content processes currently.
|
||
Updated•5 years ago
|
Has Regression Range: --- → yes
Keywords: regression
|
||
Comment 2•5 years ago
|
||
Type: enhancement → defect
|
||
Updated•5 years ago
|
Priority: -- → P3
Pushed by cmccormack@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/760a694ec6ef
Don't warn when trying to get a widget-specific vsync source. r=lsalzman
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox77:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in
before you can comment on or make changes to this bug.
Description
•