Poison.cpp: use unary 'static_assert' when the string literal is an empty string
Categories
(Developer Infrastructure :: Source Code Analysis, task)
Tracking
(firefox77 fixed)
Tracking | Status | |
---|---|---|
firefox77 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: shishirlearnz, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [lang=C++])
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
Filling as a good first bug to learn workflows.
, "");
at the end of static_assert
is useless
https://searchfox.org/mozilla-central/source/mfbt/Poison.cpp#126-127
Please fix the two occurrences
As the change is trivial, it is just to learn how to contribute to Firefox.
Found by http://clang.llvm.org/extra/clang-tidy/checks/modernize-unary-static-assert.html
Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html
Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.
Also, please only work on two max of such bugs.
Assignee | ||
Comment 1•5 years ago
|
||
I believe this was done since a 2nd param was mandatory before C++17. Instead of dropping it altogether, shouldn't it be replaced with a relevant message? Not sure if the check was already made in one of the callers in the stack frame?
Assignee | ||
Comment 2•5 years ago
|
||
The seconds argument for diagnostic message is optional from C++17
Updated•5 years ago
|
Comment 4•5 years ago
|
||
bugherder |
Updated•2 years ago
|
Description
•