Closed Bug 1629429 Opened 5 years ago Closed 5 years ago

Poison.cpp: use unary 'static_assert' when the string literal is an empty string

Categories

(Developer Infrastructure :: Source Code Analysis, task)

task
Not set
normal

Tracking

(firefox77 fixed)

RESOLVED FIXED
mozilla77
Tracking Status
firefox77 --- fixed

People

(Reporter: Sylvestre, Assigned: shishirlearnz, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [lang=C++])

Attachments

(1 file)

Filling as a good first bug to learn workflows.

, ""); at the end of static_assert is useless

https://searchfox.org/mozilla-central/source/mfbt/Poison.cpp#126-127
Please fix the two occurrences

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/modernize-unary-static-assert.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Also, please only work on two max of such bugs.

I believe this was done since a 2nd param was mandatory before C++17. Instead of dropping it altogether, shouldn't it be replaced with a relevant message? Not sure if the check was already made in one of the callers in the stack frame?

The seconds argument for diagnostic message is optional from C++17

Assignee: nobody → shishirlearnz
Status: NEW → ASSIGNED
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7141fcbeef99 Removing optional second argument in static_assert() r=sylvestre
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: