Show size details in a tooltip
Categories
(DevTools :: Netmonitor, enhancement, P3)
Tracking
(Not tracked)
People
(Reporter: Honza, Unassigned, Mentored)
References
(Blocks 2 open bugs)
Details
Attachments
(2 files)
The Size
and Transferred
columns should offer tooltips with detailed size info.
Size column:
- show size of the resource only - i.e. response body (no headers, no post data included)
Transferred column:
- show size of POST data in bytes
- show size of request headers + also in bytes
- show size of response headers + also in bytes
- show size of the response body + also in bytes
This is something I am missing a lot.
Also, not that Chrome has column Size that show the transferred size (see the attached screenshot).
Should we work on parity here?
Honza
Reporter | ||
Comment 1•5 years ago
|
||
Some instructions:
-
Transferred column title is rendered here:
https://searchfox.org/mozilla-central/rev/b7f3977978922d44c7d92ae01c0d4cc2baca7bc2/devtools/client/netmonitor/src/components/request-list/RequestListColumnTransferredSize.js#80 -
Size column title is rendered here:
https://searchfox.org/mozilla-central/rev/b7f3977978922d44c7d92ae01c0d4cc2baca7bc2/devtools/client/netmonitor/src/components/request-list/RequestListColumnContentSize.js#31
Honza
Reporter | ||
Comment 2•5 years ago
|
||
Harald, what do you think?
Any further improvements to the tooltips?
Honza
Comment 3•5 years ago
|
||
Hi, Honza
Can I work on this ?
thanks
Tim
Comment 4•5 years ago
|
||
Any further improvements to the tooltips?
Pretty complete list, thank you!
One addition I can think of is the compression rate for the response.
Would it make sense to have the same tooltip for both columns, so one of those columns can be disabled and all information still accessed?
Reporter | ||
Comment 5•5 years ago
|
||
(In reply to :Harald Kirschner :digitarald from comment #4)
One addition I can think of is the compression rate for the response.
Yep, I like that.
Would it make sense to have the same tooltip for both columns, so one of those columns can be disabled and all information still accessed?
Also good idea.
(In reply to tim.chenbw from comment #3)
Can I work on this ?
Assigned to you, thanks for the help.
Honza
Reporter | ||
Updated•4 years ago
|
Comment 7•3 years ago
|
||
The bug assignee didn't login in Bugzilla in the last 7 months.
:Honza, could you have a look please?
For more information, please visit auto_nag documentation.
Reporter | ||
Comment 8•3 years ago
|
||
Still a feature we'd like to have, but not a priority for the team atm.
But, if anyone is interested, patches are welcome!
Honza
Comment 9•2 years ago
|
||
Hello Jan, I'm interested to work on this.
I think all the needed data for the tooltip is in the request object, I should not have to compute sizes on the client side.
Reporter | ||
Comment 10•2 years ago
|
||
Assigned to you, thank you for the help.
Comment 11•2 years ago
|
||
Comment 12•2 years ago
|
||
Hello, I just submitted a patch for this feature.
Who should I assign as reviewer ?
Colin
Comment 13•2 years ago
|
||
Hi Colin,
You can assign me as a reviewer. I can take a look.
Reporter | ||
Comment 14•2 years ago
|
||
Bomsy, I just assigned you, thank you for the help
Comment 15•1 year ago
|
||
The bug assignee is inactive on Bugzilla, so the assignee is being reset.
Description
•