Closed
Bug 1629499
Opened 5 years ago
Closed 5 years ago
SeaMonkey's DownloadsCommon.jsm still uses getComplexValue
Categories
(SeaMonkey :: Download & File Handling, defect)
SeaMonkey
Download & File Handling
Tracking
(seamonkey2.49esr unaffected, seamonkey2.53 affected, seamonkey2.57esr affected)
RESOLVED
FIXED
seamonkey 2.74
| Tracking | Status | |
|---|---|---|
| seamonkey2.49esr | --- | unaffected |
| seamonkey2.53 | --- | affected |
| seamonkey2.57esr | --- | affected |
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
References
Details
(Whiteboard: SM2.53.3)
Attachments
(1 file)
|
(deleted),
patch
|
frg
:
review+
frg
:
approval-comm-release+
frg
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
Bug 1415567 made the changes for comm repo but Bug 888915 landed after that and unfortunately this didn't get picked up as part of Bug 888915. The getComplexValue -> getStringPref change still needs to happen for SeaMonkey's DownloadsCommon.jsm
[Approval Request Comment]
Regression caused by (bug #): 1414096
User impact if declined: On 2.57+ call no longer works, on 2.53 call is still supported but getStringPref would be preferred
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: none
Attachment #9140097 -
Flags: review?(frgrahl)
Attachment #9140097 -
Flags: approval-comm-release?
Attachment #9140097 -
Flags: approval-comm-esr60?
|
||
Comment 2•5 years ago
|
||
Comment on attachment 9140097 [details] [diff] [review]
Switch to getStringPref
LGTM
Attachment #9140097 -
Flags: review?(frgrahl)
Attachment #9140097 -
Flags: review+
Attachment #9140097 -
Flags: approval-comm-release?
Attachment #9140097 -
Flags: approval-comm-release+
Attachment #9140097 -
Flags: approval-comm-esr60?
Attachment #9140097 -
Flags: approval-comm-esr60+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/82a6cd4c38f2
SeaMonkey's DownloadsCommon.jsm still uses getComplexValue. r=frg
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
|
|
||
Comment 4•5 years ago
|
||
Scheduled for 2.53.3
status-seamonkey2.53:
--- → affected
status-seamonkey2.57esr:
--- → affected
Target Milestone: --- → seamonkey 2.74
You need to log in
before you can comment on or make changes to this bug.
Description
•