Closed Bug 1630312 Opened 5 years ago Closed 5 years ago

lucetc toolchain task broken with latest rust 1.44 nightly

Categories

(Firefox Build System :: General, defect)

defect

Tracking

(firefox77 fixed)

RESOLVED FIXED
mozilla77
Tracking Status
firefox77 --- fixed

People

(Reporter: away, Assigned: shravanrn)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

I haven't checked, but I think it should be as simple as updating lucet's proptest to 0.9.6.


[task 2020-04-15T16:11:17.075Z] error[E0495]: cannot infer an appropriate lifetime for lifetime parameter `'a` due to conflicting requirements
[task 2020-04-15T16:11:17.075Z]   --> /builds/worker/.cargo/registry/src/github.com-1ecc6299db9ec823/proptest-0.9.4/src/arbitrary/_core/iter.rs:47:23
[task 2020-04-15T16:11:17.075Z]    |
[task 2020-04-15T16:11:17.075Z] 47 |         base.prop_map(Iterator::cloned).boxed()
[task 2020-04-15T16:11:17.075Z]    |                       ^^^^^^^^^^^^^^^^
[task 2020-04-15T16:11:17.075Z]    |
[task 2020-04-15T16:11:17.076Z] note: first, the lifetime cannot outlive the lifetime `'a` as defined on the impl at 36:9...
[task 2020-04-15T16:11:17.076Z]   --> /builds/worker/.cargo/registry/src/github.com-1ecc6299db9ec823/proptest-0.9.4/src/arbitrary/_core/iter.rs:36:9
[task 2020-04-15T16:11:17.076Z]    |
[task 2020-04-15T16:11:17.076Z] 36 |         'a,
[task 2020-04-15T16:11:17.076Z]    |         ^^
[task 2020-04-15T16:11:17.076Z] note: ...so that the types are compatible
[task 2020-04-15T16:11:17.076Z]   --> /builds/worker/.cargo/registry/src/github.com-1ecc6299db9ec823/proptest-0.9.4/src/arbitrary/_core/iter.rs:47:23
[task 2020-04-15T16:11:17.076Z]    |
[task 2020-04-15T16:11:17.076Z] 47 |         base.prop_map(Iterator::cloned).boxed()
[task 2020-04-15T16:11:17.076Z]    |                       ^^^^^^^^^^^^^^^^
[task 2020-04-15T16:11:17.076Z]    = note: expected  `&'a T`
[task 2020-04-15T16:11:17.076Z]               found  `&T`
[task 2020-04-15T16:11:17.076Z]    = note: but, the lifetime must be valid for the static lifetime...
[task 2020-04-15T16:11:17.076Z] note: ...so that the type `strategy::map::Map<S, fn(A) -> core::iter::Cloned<A> {<A as core::iter::Iterator>::cloned::<'_, T>}>` will meet its required lifetime bounds
[task 2020-04-15T16:11:17.076Z]   --> /builds/worker/.cargo/registry/src/github.com-1ecc6299db9ec823/proptest-0.9.4/src/arbitrary/_core/iter.rs:47:41
[task 2020-04-15T16:11:17.076Z]    |
[task 2020-04-15T16:11:17.077Z] 47 |         base.prop_map(Iterator::cloned).boxed()
[task 2020-04-15T16:11:17.077Z]    |                                         ^^^^^
[task 2020-04-15T16:11:17.077Z] 
[task 2020-04-15T16:11:19.696Z] error: aborting due to previous error

Repro'd and tested that prop 0.96 fixes this.

Assignee: nobody → shravanrn

I have made the change upstream in the fork of lucet being used. Upstream commit visible here and pulled in the changes. I don't have permission to land code in mozilla-central, so could I bother you to land this from the phab?

Flags: needinfo?(dmajor)

Sure, no problem.

Flags: needinfo?(dmajor)
Pushed by dmajor@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/53178eb247b2 Bump to lucetc with prop 0.9.6 dependency for rust 1.44 support r=dmajor
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: