Honestly, common.css should just apply normally here... Shadow DOM style scoping doesn't look particularly helpful for the list items.

Wait is that how it looks for you in dark mode? On OSX everything is readable for me.

Oh, nope, my setting didn't apply correctly, now I can see it. That's not ideal. Carolina, would you have time to try and fix this?

Hey Johann! Unfortunately I have not had much time these days, but I know someone who is starting their contributions with Firefox who could help with this! Is it a good bug for beginners? Thanks!

Maybe! I think the issue is that we're overwriting these colors from common.css here. Tim, can you recommend an alternate set of variables to use? :)

Thanks!

(In reply to Johann Hofmann [:johannh] from comment #4)

Maybe! I think the issue is that we're overwriting these colors from common.css here. Tim, can you recommend an alternate set of variables to use? :)

Thanks!

Maybe:

• box-background
• box-background-hover
• box-border-color

would work.

Hello, I'm new here. I would like to work on this bug If nobody is working on it, yet.

(In reply to Vanessa from comment #6)

Hello, I'm new here. I would like to work on this bug If nobody is working on it, yet.

Hi. Nobody is working on this yet. To expand on comment 5, Tim was referring to these CSS variables that can be used as colors:

var(--in-content-box-background)
var(--in-content-box-background-hover)
var(--in-content-box-border-color)

Let me know if you have further questions.

Thanks for picking this up!

This bug is now on release. Vanessa are you still interested in fixing this?

Hi, if no one is still interested on fixing this, I would like to take it up. Thanks :)

Hey, thanks, feel free to submit a patch. Getting started documentation is here: https://firefox-source-docs.mozilla.org/setup/getting_set_up.html

Instructions for solving this particular bug should be in the previous comments, but please let me know if you have any questions.

Replaced the hardcoded background color and color to use CSS properties provided by theme so that the colors look right on dark theme

I do think this should be uplifted, some users have noticed it on release.

Comment on attachment 9154581 [details]
Bug 1630327 - Fix unreadable list view in about:certificate on dark theme.

Beta/Release Uplift Approval Request

• User impact if declined: See attachment 9140805 [details] , some release users have noticed this bug.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Go to about:certificate with the system dark mode enabled
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Straightforward CSS fix
• String changes made/needed: no

https://hg.mozilla.org/mozilla-central/rev/6b68c80e9dec

Comment on attachment 9154581 [details]
Bug 1630327 - Fix unreadable list view in about:certificate on dark theme.

approved for 78.0b5

https://hg.mozilla.org/releases/mozilla-beta/rev/e4d5d4a9333e

Reproduced the initial issue with an old Nightly build 77.0a1 (build id: 20200415215103) and Beta 78.0b4.
Verified - Fixed in latest Nightly build 79.0a1 (build id: 20200608213811) and Beta 78.0b5 (build id: 20200608141654) using Windows 10.