Replace MOZ_MUST_USE with [[nodiscard]] in netwerk
Categories
(Core :: Networking, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox77 | --- | fixed |
People
(Reporter: cpeterson, Assigned: cpeterson)
References
Details
(Whiteboard: [necko-triaged])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
The MOZ_MUST_USE macro is defined as clang's and gcc's nonstandard attribute((warn_unused_result)). Now that we compile as C++17 by default (bug 1560664), we can replace MOZ_MUST_USE with C++17's standard [[nodiscard]] attribute.
Also move MOZ_MUST_USE before function declarations' specifiers and return type. While clang and gcc's attribute((warn_unused_result)) can appear before, between, or after function specifiers and return types, the [[nodiscard]] attribute must precede the function specifiers.
|
Assignee | |
Comment 1•5 years ago
|
||
Also move MOZ_MUST_USE before function declarations' specifiers and return type. While clang and gcc's attribute((warn_unused_result)) can appear before, between, or after function specifiers and return types, the [[nodiscard]] attribute must precede the function specifiers.
|
||
Updated•4 years ago
|
|
||
Updated•4 years ago
|
Pushed by cpeterson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/09cf4a063a09 Replace MOZ_MUST_USE with [[nodiscard]] in netwerk. r=necko-reviewers,dragana
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Description
•