Notify when MediaTrackGraph has started
Categories
(Core :: Audio/Video: MediaStreamGraph, defect, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox77 | --- | fixed |
People
(Reporter: achronop, Assigned: achronop)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
The existing MTG::NotifyWhenGraphStarted logic has been modified to work for any track and not only AudioNodeTrack. Also, a unit test has been created to verify the behavior.
This is needed for setSinkId, and to solve and android intermittent.
|
Assignee | |
Comment 1•5 years ago
|
||
The existing MTG::NotifyWhenGraphStarted() has been modified to work with a MediaTrack (the parent) instead of AudioNodeTrack. Also, a unit test has been added to verify the behavior.
|
||
Updated•5 years ago
|
|
|
Assignee | |
Comment 2•5 years ago
|
||
|
|
Assignee | |
Comment 3•5 years ago
|
||
The problem, in the try run from above, is that the processing of the audio begins from the fallback thread. However, with this patch, the state of AudioContext changes to "running" later on, in the audio thread. Since the audio is being processed already from the fallback thread it was a mistake to resolve the promise of the MTG::NotifyWhenGraphStarted() in the audio thread. I will change the patch to restore that logic and will create a new method that the returned promise will resolve in the audio thread.
|
|
||
Updated•5 years ago
|
|
|
Assignee | |
Comment 4•5 years ago
|
||
|
|
||
Updated•5 years ago
|
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
Description
•