Closed Bug 1631030 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 23066 - [css-grid] Migrate grid-self-baseline-* tests to WPT

Categories

(Core :: Layout: Grid, task, P4)

Product:
Core
Component:
Layout: Grid
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla77
Tracking Flags:
Tracking Status
firefox77 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 23066 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23066
Details from upstream follow.

Mario Sanchez Prada <mario@igalia.com> wrote:

[css-grid] Migrate grid-self-baseline-* tests to WPT

Migrate all these tests out of blink/web_tests/fast/css-grid-layout
and into the WPT-specific directory, adding links to the relevant
specs and a test assertion describing its purpose.

This is a fairly big CL because it migrates 28 tests at once, but
we decided to do that since the changes done for all those tests
are pretty much the same, so both the ellaboration of this patch
and the review migth become easier this way, as changes are quite
mechanical in general.

Bug: 767015, 1063749
Change-Id: Ib19287254bf6aa70553ba805b2844e36884f52e7
Reviewed-on: https://chromium-review.googlesource.com/2154945
WPT-Export-Revision: 4f1b0f7a9e57f2089f7c1c3d278549221ee7fae3

Component: web-platform-tests → Layout: Grid
Product: Testing → Core

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 29 tests

Status Summary

Firefox

PASS: 17[Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] 19[Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, GitHub]
FAIL: 10[Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, GitHub] 12[Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt]

Chrome

PASS: 29

Safari

PASS: 29

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/css/css-grid/alignment/self-baseline/grid-self-baseline-006.html: FAIL
/css/css-grid/alignment/self-baseline/grid-self-baseline-002-b.html: FAIL
/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-lr-007.html: FAIL
/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-rl-002.html: FAIL
/css/css-grid/alignment/self-baseline/grid-self-baseline-004.html: FAIL
/css/css-grid/alignment/self-baseline/grid-self-baseline-horiz-007.html: FAIL
/css/css-grid/alignment/self-baseline/grid-self-baseline-003.html: FAIL
/css/css-grid/alignment/self-baseline/grid-self-baseline-007.html: FAIL
/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-rl-003.html: FAIL
/css/css-grid/alignment/self-baseline/grid-self-baseline-002.html: FAIL

New Tests That Don't Pass

/css/css-grid/alignment/self-baseline/grid-self-baseline-006.html: FAIL (Chrome: PASS, Safari: PASS)
/css/css-grid/alignment/self-baseline/grid-self-baseline-002-b.html: FAIL (Chrome: PASS, Safari: PASS)
/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-lr-004.html: FAIL [Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt], PASS [Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, GitHub] (Chrome: PASS, Safari: PASS)
/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-rl-004.html: FAIL [Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt], PASS [Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, GitHub] (Chrome: PASS, Safari: PASS)
/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-lr-007.html: FAIL (Chrome: PASS, Safari: PASS)
/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-rl-002.html: FAIL (Chrome: PASS, Safari: PASS)
/css/css-grid/alignment/self-baseline/grid-self-baseline-004.html: FAIL (Chrome: PASS, Safari: PASS)
/css/css-grid/alignment/self-baseline/grid-self-baseline-horiz-007.html: FAIL (Chrome: PASS, Safari: PASS)
/css/css-grid/alignment/self-baseline/grid-self-baseline-003.html: FAIL (Chrome: PASS, Safari: PASS)
/css/css-grid/alignment/self-baseline/grid-self-baseline-007.html: FAIL (Chrome: PASS, Safari: PASS)
/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-rl-003.html: FAIL (Chrome: PASS, Safari: PASS)
/css/css-grid/alignment/self-baseline/grid-self-baseline-002.html: FAIL (Chrome: PASS, Safari: PASS)

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 29 tests

Status Summary

Firefox

PASS: 17[Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] 19[Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, GitHub]
FAIL: 10[Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, GitHub] 12[Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt]

Chrome

PASS: 29

Safari

PASS: 29

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/css/css-grid/alignment/self-baseline/grid-self-baseline-006.html: FAIL
/css/css-grid/alignment/self-baseline/grid-self-baseline-002-b.html: FAIL
/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-lr-007.html: FAIL
/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-rl-002.html: FAIL
/css/css-grid/alignment/self-baseline/grid-self-baseline-004.html: FAIL
/css/css-grid/alignment/self-baseline/grid-self-baseline-horiz-007.html: FAIL
/css/css-grid/alignment/self-baseline/grid-self-baseline-003.html: FAIL
/css/css-grid/alignment/self-baseline/grid-self-baseline-007.html: FAIL
/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-rl-003.html: FAIL
/css/css-grid/alignment/self-baseline/grid-self-baseline-002.html: FAIL

New Tests That Don't Pass

/css/css-grid/alignment/self-baseline/grid-self-baseline-006.html: FAIL (Chrome: PASS, Safari: PASS)
/css/css-grid/alignment/self-baseline/grid-self-baseline-002-b.html: FAIL (Chrome: PASS, Safari: PASS)
/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-lr-004.html: FAIL [Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt], PASS [Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, GitHub] (Chrome: PASS, Safari: PASS)
/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-rl-004.html: FAIL [Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt], PASS [Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, GitHub] (Chrome: PASS, Safari: PASS)
/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-lr-007.html: FAIL (Chrome: PASS, Safari: PASS)
/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-rl-002.html: FAIL (Chrome: PASS, Safari: PASS)
/css/css-grid/alignment/self-baseline/grid-self-baseline-004.html: FAIL (Chrome: PASS, Safari: PASS)
/css/css-grid/alignment/self-baseline/grid-self-baseline-horiz-007.html: FAIL (Chrome: PASS, Safari: PASS)
/css/css-grid/alignment/self-baseline/grid-self-baseline-003.html: FAIL (Chrome: PASS, Safari: PASS)
/css/css-grid/alignment/self-baseline/grid-self-baseline-007.html: FAIL (Chrome: PASS, Safari: PASS)
/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-rl-003.html: FAIL (Chrome: PASS, Safari: PASS)
/css/css-grid/alignment/self-baseline/grid-self-baseline-002.html: FAIL (Chrome: PASS, Safari: PASS)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1b478a07a922 [wpt PR 23066] - [css-grid] Migrate grid-self-baseline-* tests to WPT, a=testonly https://hg.mozilla.org/integration/autoland/rev/47a7f5dff41b [wpt PR 23066] - Update wpt metadata, a=testonly
Pushed by archaeopteryx@coole-files.de: https://hg.mozilla.org/integration/autoland/rev/a02d13b89367 [wpt PR 23066] - [css-grid] Migrate grid-self-baseline-* tests to WPT, a=testonly https://hg.mozilla.org/integration/autoland/rev/3f30776b19fe [wpt PR 23066] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/a02d13b89367
https://hg.mozilla.org/mozilla-central/rev/3f30776b19fe

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox77: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in before you can comment on or make changes to this bug.