Closed
Bug 1631439
Opened 5 years ago
Closed 5 years ago
Rewrite callers of document.createElementNS(XUL_NS, ...) to use document.createXULElement(...)
Categories
(Firefox :: General, enhancement, P1)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 77
| Tracking | Status | |
|---|---|---|
| firefox77 | --- | fixed |
People
(Reporter: ntim, Assigned: aarushivij)
References
Details
(Keywords: good-first-bug)
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
+++ This bug was initially created as a clone of Bug #1479538 +++
As discussed in https://bugzilla.mozilla.org/show_bug.cgi?id=1479050#c3 and https://bugzilla.mozilla.org/show_bug.cgi?id=1479050#c4, we are planning to add a new chrome-only API called document.createXULElement(el) as sugar around document.createElementNS(XUL_NS, el).
Once we land that, we can migrated existing callers like
- https://searchfox.org/mozilla-central/search?q=createElementNS(XUL_NS&case=false®exp=false&path=
And then remove the const XUL_NS declarations (assuming they aren't used anywhere else in scope).
|
Reporter | |
Comment 1•5 years ago
|
||
document.createElementNS(XUL_NS, needs to be replaced with document.createXULElement( in the non-test occurrences only. And the associated XUL_NS definition should be removed (if unused).
Keywords: good-first-bug
|
Assignee | |
Comment 2•5 years ago
|
||
Hello, Can I take this bug?
Thanks :)
Aarushi
Flags: needinfo?(ntim.bugs)
|
|
Assignee | |
Comment 4•5 years ago
|
||
|
||
Updated•5 years ago
|
Assignee: nobody → aarushivij
Status: NEW → ASSIGNED
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/d363e96d98f5
Rewrite callers of document.createElementNS(XUL_NS, ...) to use document.createXULElement(...) r=ntim
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox77:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 77
You need to log in
before you can comment on or make changes to this bug.
Description
•