Closed
Bug 1631548
Opened 5 years ago
Closed 5 years ago
Remove unused methods from nsFrameLoader::InitializeFromBrowserParent()
Categories
(Core :: DOM: Navigation, task)
Core
DOM: Navigation
Tracking
()
RESOLVED
FIXED
mozilla77
| Tracking | Status | |
|---|---|---|
| firefox77 | --- | fixed |
People
(Reporter: tetsuharu, Assigned: tetsuharu)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
These methods are unused now and I seem their origin is to support mozbrowser.
nsGenericHTMLFrameElement::CreateRemoteFrameLoader()nsGenericHTMLFrameElement::AllowCreateFrameLoader()nsGenericHTMLFrameElement::DisallowCreateFrameLoader()nsFrameLoader::InitializeFromBrowserParent()
|
Assignee | |
Comment 1•5 years ago
|
||
This removes:
nsGenericHTMLFrameElement::CreateRemoteFrameLoader()nsGenericHTMLFrameElement::AllowCreateFrameLoader()nsGenericHTMLFrameElement::DisallowCreateFrameLoader()
These were moved from nsIMozBrowserFrame interface in bug 1525720.
|
||
Updated•5 years ago
|
Assignee: nobody → tetsuharu.ohzeki
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•5 years ago
|
||
Setters for this field are removed in the previous commit.
This field is always false. We can remove it.
|
|
Assignee | |
Comment 3•5 years ago
|
||
There is no caller.
Pushed by tetsuharu.ohzeki@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/acc9900e6229
part 1: Remove unused methods from nsGenericHTMLFrameElement. r=emilio
https://hg.mozilla.org/integration/autoland/rev/0f55a3bb212a
part 2: Remove nsGenericHTMLFrameElement::mFrameLoaderCreationDisallowed. r=emilio
https://hg.mozilla.org/integration/autoland/rev/d13a0f2b5a6a
part 3: Remove unused nsFrameLoader::InitializeFromBrowserParent(). r=emilio
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/acc9900e6229
https://hg.mozilla.org/mozilla-central/rev/0f55a3bb212a
https://hg.mozilla.org/mozilla-central/rev/d13a0f2b5a6a
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox77:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in
before you can comment on or make changes to this bug.
Description
•