Replace MOZ_MUST_USE with [[nodiscard]] in dom/indexedDB
Categories
(Core :: Storage: IndexedDB, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox77 | --- | fixed |
People
(Reporter: cpeterson, Assigned: cpeterson)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
The MOZ_MUST_USE macro is defined as clang's and gcc's nonstandard attribute((warn_unused_result)). Now that we compile as C++17 by default (bug 1560664), we can replace MOZ_MUST_USE with C++17's standard [[nodiscard]] attribute.
Also move MOZ_MUST_USE before function declarations' specifiers and return type. While clang and gcc's attribute((warn_unused_result)) can appear before, between, or after function specifiers and return types, the [[nodiscard]] attribute must precede the function specifiers.
|
Assignee | |
Comment 1•4 years ago
|
||
Also move MOZ_MUST_USE before function declarations' specifiers and return type. While clang and gcc's attribute((warn_unused_result)) can appear before, between, or after function specifiers and return types, the [[nodiscard]] attribute must precede the function specifiers.
|
||
Updated•4 years ago
|
Pushed by cpeterson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6bbecc3020b7 Replace MOZ_MUST_USE with [[nodiscard]] in dom/indexedDB. r=dom-workers-and-storage-reviewers,sg
Pushed by dluca@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d8eecc663784 acked out changeset 6bbecc3020b7 for build bustage in bindings/IDBObjectStoreBinding.cpp. CLOSED TREE
|
||
Comment 4•4 years ago
|
||
Backed out changeset 6bbecc3020b7 (bug 1631684) for build bustage in bindings/IDBObjectStoreBinding.cpp. CLOSED TREE
Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=298774040&repo=autoland&lineNumber=22784
Backout:
https://hg.mozilla.org/integration/autoland/rev/d8eecc663784c8463af1d2bc3f91f8078c7e1940
Chris: Can you please open the revision on phabricator? I deleted the b from backout in the commit message and the system didn't opened it automatically because of that.
|
|
Assignee | |
Comment 5•4 years ago
|
||
(In reply to Dorel Luca [:dluca] from comment #4)
Chris: Can you please open the revision on phabricator? I deleted the b from backout in the commit message and the system didn't opened it automatically because of that.
Sure. I reopened revision:
https://phabricator.services.mozilla.com/D71713#2186118
The build broke after a bad merge conflict resolution. I'll double-check the build on Try before re-landing.
|
||
Comment 6•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/6bbecc3020b7
https://hg.mozilla.org/mozilla-central/rev/d8eecc663784
Pushed by cpeterson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2d3187f93185 Replace MOZ_MUST_USE with [[nodiscard]] in dom/indexedDB. r=dom-workers-and-storage-reviewers,sg
|
||
Comment 8•4 years ago
|
||
| bugherder | ||
Description
•