Closed Bug 1631776 Opened 5 years ago Closed 5 years ago

Another round of ImageDocument cleanup.

Categories

(Core :: DOM: Core & HTML, defect, P2)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(6 files, 2 obsolete files)

Bug 1631776 - Convert some imagedocument prefs to static prefs. r=smaug
(deleted), text/x-phabricator-request
Details
Bug 1631776 - Miscellaneous cleanups on ImageDocument. r=smaug
(deleted), text/x-phabricator-request
Details
Bug 1631776 - Remove ImageDocument.restoreImageTo. r=smaug
(deleted), text/x-phabricator-request
Details
Bug 1631776 - Track less state about overflow in ImageDocument. r=smaug
(deleted), text/x-phabricator-request
Details
Bug 1631776 - Store an HTMLImageElement in ImageDocument. r=smaug
(deleted), text/x-phabricator-request
Details
Bug 1631776 - Unifdef ImageDocument's resolution logic. r=botond
(deleted), text/x-phabricator-request
Details
No description provided.

This effectively already happens on Firefox.

Android doesn't use full zoom so this is also shouldn't affect it, and it seems
reasonable behavior.

Depends on D71753

The comment no longer made any sense, and IgnoreErrors() is nicer than
manually doing so.

Depends on D71754

It's what it wants, really.

Depends on D71755

Unused except for one caller that can just be inlined.

Depends on D71756

The overflow can be inferred from other variables.

Depends on D71757

Saves a few QIs and such.

Depends on D71758

This was copy-pasta from the full-zoom code I'm changing in other patches in
this bug. However this code seems slightly more wrong: if mOriginalResolution
was somehow not 1.0, it seems to me like the right behavior would be to allow
resizing the image if the user zooms out. This patch allows that, and is
simpler, and not android-specific.

Keywords: leave-open
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/248a7a6c782e Convert some imagedocument prefs to static prefs. r=smaug
Attachment #9142039 - Attachment is obsolete: true
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fc6e3f356b0d Miscellaneous cleanups on ImageDocument. r=smaug https://hg.mozilla.org/integration/autoland/rev/2f88dd16b396 Remove ImageDocument.restoreImageTo. r=smaug https://hg.mozilla.org/integration/autoland/rev/b6f193afd449 Track less state about overflow in ImageDocument. r=smaug https://hg.mozilla.org/integration/autoland/rev/6da46fc6472c Store an HTMLImageElement in ImageDocument. r=smaug
Attachment #9142037 - Attachment is obsolete: true
Priority: -- → P2
Attachment #9142048 - Attachment description: Bug 1631776 - Don't store original resolution on ImageDocument. r=botond → Bug 1631776 - Unifdef ImageDocument's resolution logic. r=botond
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7d776a0e1331 Unifdef ImageDocument's resolution logic. r=botond
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: