[wpt-sync] Sync PR 23158 - Correct input connection and automatic pull behavior of AudioWorkletNode
Categories
(Core :: Web Audio, task, P4)
Tracking
()
Tracking | Status | |
---|---|---|
firefox77 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 23158 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/23158
Details from upstream follow.
Hongchan Choi <hongchan@chromium.org> wrote:
Correct input connection and automatic pull behavior of AudioWorkletNode
This CL fixes a failing test (process-parameters.https.html) and
it needs two changes in AudioWorkletNode:
- Handling of unconnected inputs:
- spec: https://webaudio.github.io/web-audio-api/#dom-audioworkletprocessor-process-inputs-outputs-parameters-inputs
- "If there are no actively processing AudioNodes connected to
the 𝑛th input of the AudioWorkletNode for the current render
quantum, then the content of inputs[n] is an empty array,
indicating that zero channels of input are available."- Thus, if an input is not connected, it will have an array with
zero element. (length == 0)
- Handling of automatic pull:
- The implementation did not have a proper automatic pull
functionality for AudioWorkletNode. Without connect() or
disconnect() call the node will not be automatically pulled.This change introduces failures in the "active processing" tests,
because those tests are expecting non-zero channel count for the
unconnected input:
- the-audiobuffersourcenode-interface/active-processing.https.html
- the-channelmergernode-interface/active-processing.https.html
- the-convolvernode-interface/active-processing.https.html
I perfer to mark 3 tests above "failure", and handle them later in
a separate patch.Bug: 1046516
Test: the-audioworklet-interface/process-parameters.https.html
Change-Id: I55f9a1b6eb88c172a8d050598c6e5f946fe9692b
Reviewed-on: https://chromium-review.googlesource.com/2159759
WPT-Export-Revision: 450346e6739ce1c35bb2fab8a629aab04ef6c925
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
Assignee | ||
Comment 2•5 years ago
|
||
CI Results
Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 66 tests
Status Summary
Firefox
OK : 1
PASS : 14[GitHub] 78[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt]
TIMEOUT: 1
ERROR : 1
NOTRUN : 1
Chrome
OK : 2
PASS : 19
FAIL : 3
Safari
OK : 2
PASS : 9
FAIL : 3
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
Firefox-only Failures
/webaudio/the-audio-api/the-audioworklet-interface/audioworkletnode-disconnected-input.https.html: ERROR
Audit report: NOTRUN
New Tests That Don't Pass
/webaudio/the-audio-api/the-audioworklet-interface/audioworkletnode-disconnected-input.https.html: ERROR (Chrome: OK, Safari: OK)
Audit report: NOTRUN (Chrome: PASS, Safari: PASS)
Executing "test": TIMEOUT (Chrome: PASS, Safari: FAIL)
Comment 5•5 years ago
|
||
bugherder |
Description
•