Closed Bug 1632086 Opened 5 years ago Closed 5 years ago

Content Security Policy: Couldn’t process unknown directive ‘script-src-elem’ causing all tests to timeout or fail in content-security-policy/script-src-attr-elem/ directory

Categories

(Core :: DOM: Security, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla77
Tracking Status
firefox77 --- fixed

People

(Reporter: jmaher, Assigned: jmaher)

References

Details

(Whiteboard: [domsecurity-active])

Attachments

(1 file)

there are 8 tests in the content-security-policy/script-src-attr-elem/ directory, all of them are unconditionally marked as expected timeout or fail and I can confirm that running locally. I see this in the console:
Content Security Policy: Couldn’t process unknown directive ‘script-src-elem’

I suspect this is related to bug 1632083 where the directive is 'plugin-types'.

this is slowing down test execution and wasting time.

:ckerschb, do we support 'script-src-elem'? If so, can we fix these tests?

Flags: needinfo?(ckerschb)

(In reply to Joel Maher ( :jmaher ) (UTC-4) from comment #2)

this is also the case for the 6 'style-src-attr' tests:
https://searchfox.org/mozilla-central/source/testing/web-platform/tests/content-security-policy/style-src-attr-elem

Joel, I guess we can disable both, because Firefox does not support script-src-elem and also not style-src-attr and it's not on our roadmap to support those directives anytime soon.

Flags: needinfo?(ckerschb)

a followup question- there are other tests that reference script-src-elem and style-src-attr which are in different directories, for example:
https://searchfox.org/mozilla-central/search?q=script-src-elem&path=

If the test is only ever marked as failed or timeout should I include those in a patch to mark as not-implemented (which will be the same as disabled)

Flags: needinfo?(ckerschb)

(In reply to Joel Maher ( :jmaher ) (UTC-4) from comment #4)

a followup question- there are other tests that reference script-src-elem and style-src-attr which are in different directories, for example:
https://searchfox.org/mozilla-central/search?q=script-src-elem&path=

If the test is only ever marked as failed or timeout should I include those in a patch to mark as not-implemented (which will be the same as disabled)

Yes, I think that would be great - thank you!

Flags: needinfo?(ckerschb)
Assignee: nobody → jmaher

...they include script-srcelem exception.

These are as backlog assuming Mozilla has plans to implement these features in the future.

Move wpt tests for src-src-attr-elem and style-src-attr-elem to run as backlog tsts (tier2).

Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: [domsecurity-active]
Attachment #9143891 - Attachment description: Bug 1632086 - move wpt tests for script-src-attr-elem and style-src-attr-elem to run as backlog. r=ckerschb Many tests here are also marked as backlog as they are unconditionally marked as fail/timeout for all their tests (typically 1 test) and... → Bug 1632086 - move wpt tests for script-src-attr-elem and style-src-attr-elem to run as backlog. r=ckerschbMany tests here are also marked as backlog as they are unconditionally marked as fail/timeout for all their tests (typically 1 test) and...
Pushed by jmaher@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a0fbb0c39d77 move wpt tests for script-src-attr-elem and style-src-attr-elem to run as backlog. r=ckerschb tests here are also marked as backlog as they are unconditionally marked as fail/timeout for all their tests (typically 1 test) and...
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: