Closed Bug 1632113 Opened 5 years ago Closed 5 years ago

Spidermonkey Failure TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/debug/wasm-get-return.js | Unknown (code -11, args "--baseline-eager") [0.1 s] when Gecko 77 merges to Beta on 2020-05-04

Categories

(Core :: JavaScript: WebAssembly, defect)

Product:
Core
Component:
JavaScript: WebAssembly
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla77
Tracking Flags:
Tracking Status
firefox-esr68 --- unaffected
firefox75 --- unaffected
firefox76 --- unaffected
firefox77 + verified

People

(Reporter: dluca, Assigned: wingo)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1632113 - Allow ToWebAssemblyValue / ToJSValue on i64
(deleted), text/x-phabricator-request
Details

[Tracking Requested - why for this release]:

Central as beta sim:
https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=da2bf0626e1eb2955b772e051cd00475201a0c78&selectedJob=298800386

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=298800386&repo=try&lineNumber=113744

 TEST-PASS | js/src/jit-test/tests/debug/wasm-breakpoint.js | Success (code 0, args "") [0.1 s]
[task 2020-04-22T10:50:57.003Z] TEST-PASS | js/src/jit-test/tests/debug/wasm-breakpoint.js | Success (code 0, args "--baseline-eager") [0.0 s]
[task 2020-04-22T10:50:57.003Z] TEST-PASS | js/src/jit-test/tests/debug/wasm-breakpoint.js | Success (code 59, args "--wasm-compiler=ion") [0.0 s]
[task 2020-04-22T10:50:57.012Z] TEST-PASS | js/src/jit-test/tests/debug/wasm-breakpoint.js | Success (code 0, args "--no-blinterp --no-baseline --no-ion --more-compartments") [0.1 s]
[task 2020-04-22T10:50:57.013Z] TEST-PASS | js/src/jit-test/tests/debug/wasm-breakpoint.js | Success (code 0, args "--blinterp-eager") [0.1 s]
[task 2020-04-22T10:50:57.028Z] TEST-PASS | js/src/jit-test/tests/debug/wasm-13.js | Success (code 0, args "--ion-eager --ion-offthread-compile=off --ion-check-range-analysis --ion-extra-checks --no-sse3 --no-threads") [0.1 s]
[task 2020-04-22T10:50:57.033Z] TEST-PASS | js/src/jit-test/tests/debug/wasm-13.js | Success (code 0, args "--ion-eager --ion-offthread-compile=off --more-compartments") [0.1 s]
[task 2020-04-22T10:50:57.033Z] Exit code: -11
[task 2020-04-22T10:50:57.033Z] FAIL - debug/wasm-get-return.js
[task 2020-04-22T10:50:57.033Z] TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/debug/wasm-get-return.js | Unknown (code -11, args "--baseline-eager") [0.1 s]
[task 2020-04-22T10:50:57.033Z] INFO exit-status     : -11
[task 2020-04-22T10:50:57.033Z] INFO timed-out       : False
[task 2020-04-22T10:50:57.041Z] TEST-PASS | js/src/jit-test/tests/debug/wasm-getAllColumnOffsets.js | Success (code 0, args "") [0.0 s]
[task 2020-04-22T10:50:57.043Z] Exit code: -11
[task 2020-04-22T10:50:57.043Z] FAIL - debug/wasm-get-return.js
[task 2020-04-22T10:50:57.043Z] TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/debug/wasm-get-return.js | Unknown (code -11, args "") [0.1 s]
[task 2020-04-22T10:50:57.043Z] INFO exit-status     : -11
[task 2020-04-22T10:50:57.043Z] INFO timed-out       : False
[task 2020-04-22T10:50:57.043Z] Exit code: -11
[task 2020-04-22T10:50:57.043Z] FAIL - debug/wasm-get-return.js
[task 2020-04-22T10:50:57.043Z] TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/debug/wasm-get-return.js | Unknown (code -11, args "--no-blinterp --no-baseline --no-ion --more-compartments") [0.1 s]
[task 2020-04-22T10:50:57.043Z] INFO exit-status     : -11
[task 2020-04-22T10:50:57.043Z] INFO timed-out       : False
[task 2020-04-22T10:50:57.043Z] Exit code: -11
[task 2020-04-22T10:50:57.043Z] FAIL - debug/wasm-get-return.js
[task 2020-04-22T10:50:57.044Z] TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/debug/wasm-get-return.js | Unknown (code -11, args "--blinterp-eager") [0.1 s]
[task 2020-04-22T10:50:57.044Z] INFO exit-status     : -11
[task 2020-04-22T10:50:57.044Z] INFO timed-out       : False
[task 2020-04-22T10:50:57.049Z] TEST-PASS | js/src/jit-test/tests/debug/wasm-breakpoint.js | Success (code 0, args "--ion-eager --ion-offthread-compile=off --ion-check-range-analysis --ion-extra-checks --no-sse3 --no-threads") [0.1 s]
[task 2020-04-22T10:50:57.050Z] TEST-PASS | js/src/jit-test/tests/debug/wasm-get-return.js | Success (code 59, args "--wasm-compiler=ion") [0.0 s]
[task 2020-04-22T10:50:57.050Z] TEST-PASS | js/src/jit-test/tests/debug/wasm-getAllColumnOffsets.js | Success (code 0, args "--no-blinterp --no-baseline --no-ion --more-compartments") [0.0 s]
[task 2020-04-22T10:50:57.056Z] TEST-PASS | js/src/jit-test/tests/debug/wasm-breakpoint.js | Success (code 0, args "--ion-eager --ion-offthread-compile=off --more-compartments") [0.1 s]
[task 2020-04-22T10:50:57.057Z] Exit code: -11
[task 2020-04-22T10:50:57.057Z] FAIL - debug/wasm-get-return.js
[task 2020-04-22T10:50:57.058Z] TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/debug/wasm-get-return.js | Unknown (code -11, args "--ion-eager --ion-offthread-compile=off --more-compartments") [0.1 s]
[task 2020-04-22T10:50:57.058Z] INFO exit-status     : -11
[task 2020-04-22T10:50:57.058Z] INFO timed-out       : False
[task 2020-04-22T10:50:57.058Z] TEST-PASS | js/src/jit-test/tests/debug/wasm-getAllColumnOffsets.js | Success (code 0, args "--baseline-eager") [0.0 s]
[task 2020-04-22T10:50:57.064Z] Exit code: -11
[task 2020-04-22T10:50:57.064Z] FAIL - debug/wasm-get-return.js
[task 2020-04-22T10:50:57.064Z] TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/debug/wasm-get-return.js | Unknown (code -11, args "--ion-eager --ion-offthread-compile=off --ion-check-range-analysis --ion-extra-checks --no-sse3 --no-threads") [0.1 s]
[task 2020-04-22T10:50:57.064Z] INFO exit-status     : -11
[task 2020-04-22T10:50:57.064Z] INFO timed-out       : False
[task 2020-04-22T10:50:57.064Z] TEST-PASS | js/src/jit-test/tests/debug/wasm-getAllColumnOffsets.js | Success (code 59, args "--wasm-compiler=ion") [0.0 s]
[task 2020-04-22T10:50:57.069Z] TEST-PASS | js/src/jit-test/tests/debug/wasm-getAllColumnOffsets.js | Success (code 0, args "--ion-eager --ion-offthread-compile=off --ion-check-range-analysis --ion-extra-checks --no-sse3 --no-threads") [0.1 s]
Flags: needinfo?(wingo)

No good deed goes unpunished! A better log here from a debug-mode build:

https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=298800399&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=da2bf0626e1eb2955b772e051cd00475201a0c78

i.e. the problem is that ToJSValue creats a cached JS return value from an i64, when the bigint/i64 feature is disabled, so we hit a MOZ_CRASH. Previously we would make a double from an i64 (yuck). However given that BigInt is unconditionally enabled now, I will see about making ToJSValue go ahead and make a bigint, relying on other code paths to throw an exception instead of crashing if the feature isn't supported.

Flags: needinfo?(wingo)

Even if the ENABLE_WASM_BIGINT feature is disabled, these functions can
be called for i64 types during debugging. The ENABLE_WASM_BIGINT
feature has other checks that prevent user-visible calls to these
functions, apart from the debugging interface.

Assignee: nobody → wingo
Status: NEW → ASSIGNED

(Didn't see on Nightly as ENABLE_WASM_BIGINT is set on nightly)

Pushed by wingo@igalia.com: https://hg.mozilla.org/integration/autoland/rev/ee7056a8f7f9 Allow ToWebAssemblyValue / ToJSValue on i64 r=lth

https://hg.mozilla.org/mozilla-central/rev/ee7056a8f7f9

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox77: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
Has Regression Range: --- → yes
Keywords: regression
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: