Closed Bug 1632238 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 23178 - [FlexNG] Add test for replaced %-block-size descendant.

Categories

(Core :: Layout: Flexbox, task, P4)

Product:
Core
Component:
Layout: Flexbox
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla77
Tracking Flags:
Tracking Status
firefox77 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 23178 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23178
Details from upstream follow.

Ian Kilpatrick <ikilpatrick@chromium.org> wrote:

[FlexNG] Add test for replaced %-block-size descendant.

With FlexNG we now cache on the ComputeMinMaxSizes level.
This fixes a subtle dynamic edge case.

Previously (legacy) wouldn't invalidate the flex-item base size due to
a parent height changes.

This adds a test for this case.

Bug: 845235
Change-Id: Ic711c3f8110b08fcc89351274a7bd283f66c1ce1

Reviewed-on: https://chromium-review.googlesource.com/2161431
WPT-Export-Revision: 1c4f406504b7d52fd731bc60c3d9f598e4bd1123

Component: web-platform-tests → Layout: Flexbox
Product: Testing → Core

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/28c38e708ee7 [wpt PR 23178] - [FlexNG] Add test for replaced %-block-size descendant., a=testonly
Pushed by archaeopteryx@coole-files.de: https://hg.mozilla.org/integration/autoland/rev/2452c3711188 [wpt PR 23178] - [FlexNG] Add test for replaced %-block-size descendant., a=testonly

https://hg.mozilla.org/mozilla-central/rev/2452c3711188

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox77: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in before you can comment on or make changes to this bug.