Closed Bug 1632761 Opened 5 years ago Closed 5 years ago

Consider adding IC support for JSOp::ToNumeric

Categories

(Core :: JavaScript Engine: JIT, task)

task
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla77
Tracking Status
firefox77 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

What bug 1626297 did for JSOp::Pos we should consider doing for JSOp::ToNumeric as well. These ops are very similar so optimizing them the same way makes sense.

This would slow down JSOp::ToNumeric in Baseline a bit so we should measure impact on --no-ion. It would be faster for BigInt inputs though and give us better type information in Warp.

Blocks: 1620996
No longer blocks: WarpBuilder

This is based on the similar changes for JSOp::Pos (bug 1626297 part 3).

JSOp::Pos and JSOp::ToNumeric are very similar and are now optimized the same
way. Baseline had a fast path for numbers and we now use an IC. The IC should
be faster for BigInt code and has optimizations for string inputs. This will also
give us better type information in Warp.

Blocks: 1632757
Pushed by jdemooij@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/77e67f5caa2b part 1 - Add IC support for JSOp::ToNumeric. r=evilpie https://hg.mozilla.org/integration/autoland/rev/fc5dc25fe53a part 2 - Use IC for JSOp::ToNumeric in IonBuilder. r=evilpie

This was backed out for conflicting in another backout that was requested for some SM bustages.
https://hg.mozilla.org/integration/autoland/rev/782dbe1ce52a72c02d852d73d817078d7fe3600e
jandem: We are sorry for the inconvenience!

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
Status: RESOLVED → REOPENED
Flags: needinfo?(jdemooij)
Resolution: FIXED → ---
Target Milestone: mozilla77 → ---
Flags: needinfo?(jdemooij)
Pushed by jdemooij@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d7adbc71f913 part 1 - Add IC support for JSOp::ToNumeric. r=evilpie https://hg.mozilla.org/integration/autoland/rev/7187db5fae0a part 2 - Use IC for JSOp::ToNumeric in IonBuilder. r=evilpie
Status: REOPENED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: