Consider adding IC support for JSOp::ToNumeric
Categories
(Core :: JavaScript Engine: JIT, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox77 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
What bug 1626297 did for JSOp::Pos we should consider doing for JSOp::ToNumeric as well. These ops are very similar so optimizing them the same way makes sense.
This would slow down JSOp::ToNumeric in Baseline a bit so we should measure impact on --no-ion. It would be faster for BigInt inputs though and give us better type information in Warp.
|
||
Updated•5 years ago
|
|
Assignee | |
Comment 1•5 years ago
|
||
This is based on the similar changes for JSOp::Pos (bug 1626297 part 3).
JSOp::Pos and JSOp::ToNumeric are very similar and are now optimized the same
way. Baseline had a fast path for numbers and we now use an IC. The IC should
be faster for BigInt code and has optimizations for string inputs. This will also
give us better type information in Warp.
|
|
Assignee | |
Comment 2•5 years ago
|
||
Depends on D72333
|
||
Comment 4•5 years ago
|
||
This was backed out for conflicting in another backout that was requested for some SM bustages.
https://hg.mozilla.org/integration/autoland/rev/782dbe1ce52a72c02d852d73d817078d7fe3600e
jandem: We are sorry for the inconvenience!
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/77e67f5caa2b
https://hg.mozilla.org/mozilla-central/rev/fc5dc25fe53a
|
||
Comment 6•5 years ago
|
||
Backout merged: https://hg.mozilla.org/mozilla-central/rev/782dbe1ce52a
|
|
Assignee | |
Updated•5 years ago
|
|
||
Comment 8•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/d7adbc71f913
https://hg.mozilla.org/mozilla-central/rev/7187db5fae0a
Description
•