Closed Bug 1633009 Opened 5 years ago Closed 5 years ago

The message-group provider is causing 404 error for RemoteSettings

Categories

(Firefox :: Messaging System, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 77
Iteration:
77.2 - Apr 20 - May 3
Tracking Status
firefox76 --- unaffected
firefox77 --- verified
firefox78 --- verified

People

(Reporter: nanj, Assigned: andreio, NeedInfo)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

RS client is complaining about Unknown Collection "main/message-groups" RemoteSettingsClient.jsm:137. We should create this collection on RS if we wanted to use it, if not, perhaps disable this provider for now.

Does this mean we're making requests to our remote settings server every startup and then every 6 hours only to look for something that doesn't exist? :-\

Also, do we await this result? It looks like it, which would imply that on Firefox startup we're waiting for this result to come back from the network before we can load the AS / new tab page content. That would be pretty bad...

Loading new tab page content is not delayed on these requests. It can potentially delay loading snippets which are rendered as an overlay.

Assignee: nobody → andrei.br92
Blocks: cfr
Iteration: --- → 77.2 - Apr 20 - May 3
Priority: -- → P1

Is there some work around I can use for now just so that I can get Snippets to work again? This is blocking https://bugzilla.mozilla.org/show_bug.cgi?id=1614465 now.

Flags: needinfo?(andrei.br92)

This patch will disable the Remote Settings calls.

Flags: needinfo?(andrei.br92)
Pushed by aoprea@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9ddc23f7bd72 Disable the Remote Settings message-group provider because it is not used r=k88hudson
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 77

== Change summary for alert #25778 (as of Wed, 29 Apr 2020 18:06:50 GMT) ==

Improvements:

5% raptor-tp6-netflix-firefox-cold loadtime windows7-32-shippable opt 1,874.17 -> 1,779.25
4% raptor-tp6-netflix-firefox-cold loadtime windows7-32-shippable opt 1,853.17 -> 1,783.50

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=25778

(In reply to Marian Raiciof [:marauder] from comment #9)

== Change summary for alert #25778 (as of Wed, 29 Apr 2020 18:06:50 GMT) ==

Improvements:

5% raptor-tp6-netflix-firefox-cold loadtime windows7-32-shippable opt 1,874.17 -> 1,779.25
4% raptor-tp6-netflix-firefox-cold loadtime windows7-32-shippable opt 1,853.17 -> 1,783.50

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=25778

This is pretty surprising, as this code runs on startup but shouldn't be running when opening random webpages. How sure are we this is the correct change?

Flags: needinfo?(marian.raiciof)

I have verified that this issue is no longer reproducible with the latest Firefox Beta (77.0 Build ID - 20200527121107) and latest Firefox Nightly (78.0a1 Build ID - 20200528032513) installed, on Windows 10 x64, Ubuntu 18.04 x64 and Mac 10.15.3. Now the Unknown Collection "main/message-groups" error is no longer displayed in the "Browser Console".

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: