User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:75.0) Gecko/20100101 Firefox/75.0

Steps to reproduce:

Use Linux with vanilla GNOME session (Ubuntu 20.04, in my case).

Use the current Firefox Flatpak from Flathub (although I can say that this has happened for every FF flatpak build so far.)

Hover over the minimize/maximize/close window controls.

Actual results:

The window control button is highlighted in a square shape.

Expected results:

The window control button should be highlighted in a circle shape, in accordance with the newer GTK / Adwaita versions (since GNOME 3.32, I think).

Note 1: This does not happen with RPM / DEB builds on current Linux distros.
Note 2: When the FF flatpak is "themed", e. g. "Yaru" theme on Ubuntu, this issue naturally doesn't occur.

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Jan, I guess you have already looked at it, right?
Thanks.

Theme depends on runtime version. You need to have the same theme (as system theme) installed from flathub to have both apps looking same. Here are some instructions: https://www.omgubuntu.co.uk/2017/05/flatpak-theme-issue-fix

Thank you for looking into this.

But I'm sorry, this cannot be the solution I was looking for (or at least this bug shouldn't be closed yet).

1. I can't find a GTK3 Theme called "Adwaita" in the Flathub repo (and there shouldn't be a need for it, as it is the system stylesheet).
2. I don't want to use any other "theme" than the default stylesheet (but I would be forced to with this issue?)
3. Other Flatpak apps that I use (like Geary and Lollypop) have the newer GTK window controls (the exceptions are Firefox and LibreOffice btw).

So my questions are:

• What do I need to do to have round window controls in the Firefox Flatpak just like in the Geary Flatpak?
• In case I myself can't do anything right now, shouldn't this bug remain open?

Imagine RHEL/Fedora switching to a Firefox Flatpak someday that looks inconsistent with the rest of the applications… :-)

(In reply to Tim Hofstede from comment #5)

Thank you for looking into this.

But I'm sorry, this cannot be the solution I was looking for (or at least this bug shouldn't be closed yet).

1. I can't find a GTK3 Theme called "Adwaita" in the Flathub repo (and there shouldn't be a need for it, as it is the system stylesheet).

Adwaita is build-in basic theme which is shipped as a part of Gtk3 library. It's part of the runtime and can't be changed, it's tied to actual Gtk3 version you have installed. So actual Adwaita theme version match your actual Gtk3 library version which is running Firefox.

Alright. So I have the following versions installed (Ubuntu 20.04 vanilla GNOME session):

GNOME 3.36.1
LIBGTK 3.24.18

That looks bleeding edge to me… But apparently Firefox still doesn't use the new window controls.

I remember that the Red Hat sponsered Firefox Flatpak was once built with the GNOME 3.28 runtime that still had the old window controls. Maybe this could have something to do with it?

(In reply to Tim Hofstede from comment #7)

I remember that the Red Hat sponsered Firefox Flatpak was once built with the GNOME 3.28 runtime that still had the old window controls. Maybe this could have something to do with it?

Yes, exactly. Flatpak applications are running in their own runtime and have their own libraries which are independent on the system ones. So this bug is about actual flatpak runtime libraries, not about our system ones.

Thank you for making that clear.

So, what's the way going forward her? Where else should I file this issue? (Or is this even necessary, since you are the core developers…?)

Can I expect the Firefox Flatpak runtime to move along with the RHEL applications (i. e. when GNOME applications in RHEL get upgraded to 3.32 the Firefox Flatpak will too) or some other schedule?

I have opened this issue now on the freedesktop-sdk GitLab:

https://gitlab.com/freedesktop-sdk/freedesktop-sdk/-/issues/1014

This has been fixed with the release of freedesktop-sdk-19.08.11.

Thank you! :)