In bug 1626506, we tried to vendor a crate that depends on url v2.1.1, while m-c currently vendors 2.1.0. This caused lots of assertions inside PrincipalVerifier::IsPrincipalInfoValid, like:

0:04.67 pid:94821 [94821, Main Thread] WARNING: originNoSuffix (file://///index.html) doesn't match passed one (file:///index.html)!: file /Users/lina/Code/gecko/dom/quota/ActorsParent.cpp, line 10420
0:04.67 pid:94821 Assertion failure: IsPrincipalInfoValid(principalInfo), at /Users/lina/Code/gecko/dom/quota/ActorsParent.cpp:10453

As well as the MozURL GTest, where BaseDomainsEqual returns false for these:

1 = indexeddb://fx-devtools/, 2 = indexeddb://fx-devtools
1 = indexeddb://fx-devtools/#x, 2 = indexeddb://fx-devtools#x

Jan, can we change PrincipalVerifier::IsPrincipalInfoValid to handle the new normalized origin format? I tried changing it to call QuotaManager::IsPrincipalInfoValid, since the logic looked super similar, but that caused a bunch of test failures, too (unexpected successes and "cannot find matching entry" in the IDB and QM tests).

Valentin, should we update netwerk/test/gtest/urltestdata.json with those new origins, or is there another fix we need here?

As a workaround, we can change webext_storage to depend on url 2.1.0 for now, but it would be great to bump the m-c version eventually.

(In reply to :Lina Cambridge from comment #0)

Valentin, should we update netwerk/test/gtest/urltestdata.json with those new origins, or is there another fix we need here?

If we update to 2.1.1 I believe we should be updating it to be the same as the tests we pass in rust-url:
https://github.com/servo/rust-url/blob/master/tests/urltestdata.json

As a workaround, we can change webext_storage to depend on url 2.1.0 for now, but it would be great to bump the m-c version eventually.

I also wanted to make the upgrade soon, but I don't know if I'll be able to get to it in the next month.

The latest version is 2.2.2.

I'm not sure what can be done here at this point. From storage perspective, we could try to unify the way we generate origin and domain strings. Currently we use both, MozURL (off main thread) and nsIPrincipal (on the main thread).

Depends on D186796

Depends on D186797