[wpt-sync] Sync PR 23272 - Treat floorOrigin as mojoFromFloor
Categories
(Core :: WebVR, task, P4)
Tracking
()
Tracking | Status | |
---|---|---|
firefox77 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Attachments
(1 file)
(deleted),
text/plain
|
Details |
Sync web-platform-tests PR 23272 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/23272
Details from upstream follow.
Alexander Cooper <alcooper@chromium.org> wrote:
Treat floorOrigin as mojoFromFloor
Per the webxr-test-api all origins are based on the "local" space when
the "session" started; which means that all of our origins passed in are
inherently "mojoFromFoo." The standingTransform (in need of renaming)
is, in blink and by devices, floorFromMojo. Since the tests were
directly setting floorOrigin to the standingTransform, the tests were
incorrectly treating floor origin as floorFromMojo. This change inverts
the floorOrigin before assigning it to the standingTransform, so that
Chrome begins treating the floorOrigin as mojoFromFloor. Given that
Chrome was the only ones running these particular tests, the output
values were also written as if the passed in floorOrigins were
floorFromMojo. In order to stick with the expectations, this inverts
the input transforms as well.In fixing this, a bug was discovered in XRMathHelper.inverse wherein the
comatrix was not created properly. This change also addresses that bug.Fixed:1071630
Change-Id: I1626d80099169c4ceba0df68ad84bbf181f76647
Reviewed-on: https://chromium-review.googlesource.com/2165881
WPT-Export-Revision: 04dea1d53a3b184bab59224b2a08dfa99e8f8299
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
Assignee | ||
Comment 2•5 years ago
|
||
Comment 5•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3fd0e0d83904
https://hg.mozilla.org/mozilla-central/rev/30a9a6858c57
Description
•